Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document set_name() and set_version() #1444

Merged
merged 6 commits into from Oct 25, 2019

Conversation

@memsharded
Copy link
Member

@memsharded memsharded commented Oct 18, 2019

Docs for conan-io/conan#5881

reference/conanfile/methods.rst Outdated Show resolved Hide resolved
howtos/capture_version.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
These methods are only executed when the recipe is in user space, that is, in the ``export`` and ``create`` commands, and the
``install <path>`` when the path points to a *conanfile.py* containing these methods.

See more examples :ref:`in this howto <capture_version>`.
Copy link
Member

@danimtb danimtb Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this in a .. seealso:: box

Co-Authored-By: Daniel <danimanzaneque@gmail.com>
Copy link
Contributor

@lasote lasote left a comment

Take a look at the Dani comments

@memsharded memsharded changed the title document get_name() and get_version() document set_name() and set_version() Oct 22, 2019
@memsharded memsharded requested a review from danimtb Oct 25, 2019
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
reference/conanfile/methods.rst Outdated Show resolved Hide resolved
memsharded and others added 2 commits Oct 25, 2019
Co-Authored-By: Daniel <danimanzaneque@gmail.com>
Co-Authored-By: Daniel <danimanzaneque@gmail.com>
@memsharded memsharded assigned danimtb and unassigned memsharded Oct 25, 2019
@danimtb danimtb merged commit a2b16cd into conan-io:develop Oct 25, 2019
2 checks passed
@memsharded memsharded deleted the feature/get_name_version branch Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants