Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change create command build policy documentation #1483

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@czoido
Copy link
Contributor

czoido commented Nov 26, 2019

As explained in conan-io/conan#6131 the --build policy help message was the same for the commands create, test, install and workspace but the behavior for the create command by default was not to behave as --build=never but as --build=package name which could be misleading.

@czoido czoido mentioned this pull request Nov 26, 2019
4 of 5 tasks complete
@danimtb

This comment has been minimized.

Copy link
Member

danimtb commented Nov 26, 2019

reference should be clear enough for people to understand that it refers to the reference name or should it be <reference>?

Is that really the reference or the reference name?

@czoido

This comment has been minimized.

Copy link
Contributor Author

czoido commented Nov 26, 2019

reference should be clear enough for people to understand that it refers to the reference name or should it be <reference>?

Is that really the reference or the reference name?

Yes, I think that It will be more clear with package name, reference is confusing

@danimtb danimtb self-assigned this Nov 26, 2019
@danimtb danimtb added this to the 1.21 milestone Nov 26, 2019
@danimtb danimtb merged commit 5818a73 into conan-io:develop Nov 26, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.