Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation related to settings_build and settings_target #1678

Merged
merged 3 commits into from May 6, 2020

Conversation

jgsogo
Copy link
Member

@jgsogo jgsogo commented Apr 27, 2020

devtools/build_requires.rst Outdated Show resolved Hide resolved
systems_cross_building/cross_building.rst Outdated Show resolved Hide resolved
systems_cross_building/cross_building.rst Outdated Show resolved Hide resolved
# It is running in 'build' and it is being used as a BR, 'target' can be inferred from settings
if self.options.target:
raise ConanInvalidConfiguration(f"Value for the option 'target' will be computed from settings_target")
self.options.target = get_target_from_settings(self.settings_target)
Copy link
Member

@memsharded memsharded May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This get_target_from_settings() is a bit confusing. If it is an option, I would expect to be in the input. Where is it defined? What it does?

Copy link
Member Author

@jgsogo jgsogo May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a function to get the target [value] from the settings. I'll write this function before the class with a comment.

This is the cross compiler example from the repo in https://github.com/jgsogo/conan-xbuild, when this recipe is instantiated in the build context then the value for the target option CAN be computed from the profile_host (which is the value of settings_target).

@jgsogo jgsogo requested a review from memsharded May 5, 2020
@danimtb danimtb assigned memsharded and unassigned danimtb May 6, 2020
@memsharded memsharded merged commit 21d334f into conan-io:develop May 6, 2020
2 checks passed
@jgsogo jgsogo deleted the doc/6769-xbuild-profiles branch May 6, 2020
czoido added a commit that referenced this issue May 6, 2020
* Add info about config_install_interval (#1679)

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Master (#1665)

* fix dupe changelog (#1617)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* Convert all references to lowercase (#1619)

* Convert all references to lowercase

* fix

* Update developing_packages/workspaces.rst

* Update developing_packages/workspaces.rst

* Update howtos/manage_shared_libraries/env_vars.rst

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update devtools/build_requires.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Remove linkcheck from master jobs (#1633)

* Remove old stuff from building scripts: elasticsearch, old deploy commands (#1634)

* Remove linkcheck from master jobs

* remove indexing stuff from deploy script

* remove old gh_pages script

* remove nginx script

* remove make_mac

* remove elastic stuff

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* #1506 Add Troubleshooting for duplicated package (#1507)

* #1506 Add Troubleshooting for duplicated package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #1506 Better block format

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #1506 Better block format

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Change the perspective to transitive package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Use the build folder to apply any patch (#1605)

* Use the build folder to apply any patch

Some motivation: conan-io/conan-center-index#1107 (comment)

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update build folder comment

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update reference/tools.rst

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>

* Remove redundant text in visualstudio.rst (#1625)

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Add information about matrix-params in the artifacts.properties reference (#1487)

* add matrix-params to docs

* finally landed in 7.3.2

* Update reference/config_files/artifacts.properties.rst

Co-Authored-By: Carlos Zoido <mrgalleta@gmail.com>

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* change version and changelog

* unicode char not allowed (#1649)

* Updates docs related to 'remotes.json' file (#1640)

* document remotes.json

* add note about metadata.josn

* update docs in remote command

* remove non public files

* remove unneeded change

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* fix python_requires_copy (#1647)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* add missing changelog (#1652)

* Improvement/cmake helper (#1655)

* Sort definitions in CMake helper

* Add missing definitions to CMake helper

* update example about makefiles (#1659)

* new cpplang slack inviter (#1664)

* fix typeo in command description (#1670)

* Fix typo: it's CONAN_RUN_TESTS, not CONAN_RUN_TEST (#1671)

* Release/1.24.1 (#1672)

* bump version

* add changelog

* clarify default_package_id_mode (#1666)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: syntroniks <syntroniks@gmail.com>
Co-authored-by: Aleksa Pavlovic <pavlovicaleksa@yahoo.com>
Co-authored-by: Jerry <jerrywiltse@gmail.com>
Co-authored-by: Kevin Puetz <puetzk@puetzk.org>

* Documentation related to settings_build and settings_target (#1678)

* documentation rleated to settings_build and settings_target

* review

* remove function, add comment

* update version

* add changelog

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: James <james@conan.io>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: syntroniks <syntroniks@gmail.com>
Co-authored-by: Aleksa Pavlovic <pavlovicaleksa@yahoo.com>
Co-authored-by: Jerry <jerrywiltse@gmail.com>
Co-authored-by: Kevin Puetz <puetzk@puetzk.org>
czoido added a commit that referenced this issue May 6, 2020
* fix dupe changelog (#1617)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* Convert all references to lowercase (#1619)

* Convert all references to lowercase

* fix

* Update developing_packages/workspaces.rst

* Update developing_packages/workspaces.rst

* Update howtos/manage_shared_libraries/env_vars.rst

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update devtools/build_requires.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Remove linkcheck from master jobs (#1633)

* Remove old stuff from building scripts: elasticsearch, old deploy commands (#1634)

* Remove linkcheck from master jobs

* remove indexing stuff from deploy script

* remove old gh_pages script

* remove nginx script

* remove make_mac

* remove elastic stuff

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* #1506 Add Troubleshooting for duplicated package (#1507)

* #1506 Add Troubleshooting for duplicated package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #1506 Better block format

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #1506 Better block format

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Change the perspective to transitive package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Use the build folder to apply any patch (#1605)

* Use the build folder to apply any patch

Some motivation: conan-io/conan-center-index#1107 (comment)

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update build folder comment

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update reference/tools.rst

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>

* Remove redundant text in visualstudio.rst (#1625)

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Add information about matrix-params in the artifacts.properties reference (#1487)

* add matrix-params to docs

* finally landed in 7.3.2

* Update reference/config_files/artifacts.properties.rst

Co-Authored-By: Carlos Zoido <mrgalleta@gmail.com>

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* change version and changelog

* unicode char not allowed (#1649)

* Updates docs related to 'remotes.json' file (#1640)

* document remotes.json

* add note about metadata.josn

* update docs in remote command

* remove non public files

* remove unneeded change

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* fix python_requires_copy (#1647)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* add missing changelog (#1652)

* Improvement/cmake helper (#1655)

* Sort definitions in CMake helper

* Add missing definitions to CMake helper

* update example about makefiles (#1659)

* new cpplang slack inviter (#1664)

* fix typeo in command description (#1670)

* Fix typo: it's CONAN_RUN_TESTS, not CONAN_RUN_TEST (#1671)

* Release/1.24.1 (#1672)

* bump version

* add changelog

* clarify default_package_id_mode (#1666)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* Release/1.25.0 (#1683)

* Add info about config_install_interval (#1679)

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Master (#1665)

* fix dupe changelog (#1617)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* Convert all references to lowercase (#1619)

* Convert all references to lowercase

* fix

* Update developing_packages/workspaces.rst

* Update developing_packages/workspaces.rst

* Update howtos/manage_shared_libraries/env_vars.rst

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update devtools/build_requires.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

* Update creating_packages/define_abi_compatibility.rst

Co-Authored-By: Javier G. Sogo <jgsogo@gmail.com>

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Remove linkcheck from master jobs (#1633)

* Remove old stuff from building scripts: elasticsearch, old deploy commands (#1634)

* Remove linkcheck from master jobs

* remove indexing stuff from deploy script

* remove old gh_pages script

* remove nginx script

* remove make_mac

* remove elastic stuff

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* #1506 Add Troubleshooting for duplicated package (#1507)

* #1506 Add Troubleshooting for duplicated package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #1506 Better block format

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* #1506 Better block format

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Change the perspective to transitive package

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Use the build folder to apply any patch (#1605)

* Use the build folder to apply any patch

Some motivation: conan-io/conan-center-index#1107 (comment)

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update build folder comment

Signed-off-by: Uilian Ries <uilianries@gmail.com>

* Update reference/tools.rst

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>

* Remove redundant text in visualstudio.rst (#1625)

Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>

* Add information about matrix-params in the artifacts.properties reference (#1487)

* add matrix-params to docs

* finally landed in 7.3.2

* Update reference/config_files/artifacts.properties.rst

Co-Authored-By: Carlos Zoido <mrgalleta@gmail.com>

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* change version and changelog

* unicode char not allowed (#1649)

* Updates docs related to 'remotes.json' file (#1640)

* document remotes.json

* add note about metadata.josn

* update docs in remote command

* remove non public files

* remove unneeded change

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>

* fix python_requires_copy (#1647)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

* add missing changelog (#1652)

* Improvement/cmake helper (#1655)

* Sort definitions in CMake helper

* Add missing definitions to CMake helper

* update example about makefiles (#1659)

* new cpplang slack inviter (#1664)

* fix typeo in command description (#1670)

* Fix typo: it's CONAN_RUN_TESTS, not CONAN_RUN_TEST (#1671)

* Release/1.24.1 (#1672)

* bump version

* add changelog

* clarify default_package_id_mode (#1666)

Co-authored-by: Daniel <danimanzaneque@gmail.com>

Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: syntroniks <syntroniks@gmail.com>
Co-authored-by: Aleksa Pavlovic <pavlovicaleksa@yahoo.com>
Co-authored-by: Jerry <jerrywiltse@gmail.com>
Co-authored-by: Kevin Puetz <puetzk@puetzk.org>

* Documentation related to settings_build and settings_target (#1678)

* documentation rleated to settings_build and settings_target

* review

* remove function, add comment

* update version

* add changelog

Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: James <james@conan.io>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: syntroniks <syntroniks@gmail.com>
Co-authored-by: Aleksa Pavlovic <pavlovicaleksa@yahoo.com>
Co-authored-by: Jerry <jerrywiltse@gmail.com>
Co-authored-by: Kevin Puetz <puetzk@puetzk.org>

Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Javier G. Sogo <jgsogo@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: syntroniks <syntroniks@gmail.com>
Co-authored-by: James <james@conan.io>
Co-authored-by: Aleksa Pavlovic <pavlovicaleksa@yahoo.com>
Co-authored-by: Jerry <jerrywiltse@gmail.com>
Co-authored-by: Kevin Puetz <puetzk@puetzk.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants