Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components reference to cmake_find_package_multi generator #1755

Merged

Conversation

danimtb
Copy link
Member

@danimtb danimtb commented Jun 30, 2020

@danimtb danimtb added this to the 1.27 milestone Jun 30, 2020
@danimtb danimtb requested a review from jgsogo Jun 30, 2020
@@ -46,6 +46,7 @@ A target named ``<PKG-NAME>::<PKG-NAME>`` target is generated with the following
- ``INTERFACE_INCLUDE_DIRECTORIES``: Containing all the include directories of the package.
- ``INTERFACE_LINK_LIBRARIES``: Library paths to link.
- ``INTERFACE_COMPILE_DEFINITIONS``: Definitions of the library.
- ``INTERFACE_COMPILE_OPTIONS``: Compile options of the library.
Copy link
Member Author

@danimtb danimtb Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was missing from the documentation although it is taken as an example down below

reference/generators/cmake_find_package_multi.rst Outdated Show resolved Hide resolved

Moreover, a global target ``<PKG-NAME>::<PKG-NAME>`` will be declared with the following properties adjusted:

- ``INTERFACE_LINK_LIBRARIES``: Containing all the component targets to link the global target to (includes package's components only).
Copy link
Member

@jgsogo jgsogo Jun 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ``INTERFACE_LINK_LIBRARIES``: Containing all the component targets to link the global target to (includes package's components only).
- ``INTERFACE_LINK_LIBRARIES``: Containing the list of targets for all the components in the package.

reference/generators/cmake_find_package_multi.rst Outdated Show resolved Hide resolved
danimtb and others added 3 commits Jun 30, 2020
jgsogo
jgsogo approved these changes Jul 1, 2020
@danimtb danimtb merged commit 25aad97 into conan-io:develop Jul 1, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants