Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lockfiles new #1790

Merged
merged 52 commits into from Jul 31, 2020
Merged

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jul 30, 2020

Docs for lockfiles iteration conan-io/conan#7243

memsharded and others added 2 commits Jul 30, 2020
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Copy link
Member

@danimtb danimtb left a comment

Review introduction

versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
versioning/lockfiles/introduction.rst Outdated Show resolved Hide resolved
memsharded and others added 15 commits Jul 30, 2020
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Copy link
Member

@danimtb danimtb left a comment

Review configurations

versioning/lockfiles/configurations.rst Outdated Show resolved Hide resolved
versioning/lockfiles/configurations.rst Outdated Show resolved Hide resolved
versioning/lockfiles/configurations.rst Outdated Show resolved Hide resolved
versioning/lockfiles/configurations.rst Outdated Show resolved Hide resolved
versioning/lockfiles/configurations.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
Co-authored-by: Carlos Zoido <mrgalleta@gmail.com>
Copy link
Member

@danimtb danimtb left a comment

Some corrections to avoid confusion and rephrasing.

One thing I am missing (and I am not sure if that is explained earlier in the introduction) is the concept of partial lock and full lock. I think defining those terms at the beginning will avoid repeating the definition eveytime

versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
versioning/lockfiles/build_order.rst Outdated Show resolved Hide resolved
memsharded and others added 10 commits Jul 31, 2020
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Copy link
Member

@danimtb danimtb left a comment

there are some suggestions pending from previous review. Also I'd like to have definition at the beginning of "partial lock" and "full lock". Does conan lock create --base generate a partial lock?

reference/commands/misc/lock.rst Outdated Show resolved Hide resolved
reference/commands/misc/lock.rst Outdated Show resolved Hide resolved
reference/commands/misc/lock.rst Outdated Show resolved Hide resolved
reference/commands/misc/lock.rst Outdated Show resolved Hide resolved
reference/commands/misc/lock.rst Outdated Show resolved Hide resolved
memsharded and others added 11 commits Jul 31, 2020
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
Co-authored-by: Daniel <danimanzaneque@gmail.com>
@memsharded memsharded merged commit d073c60 into conan-io:develop Jul 31, 2020
2 checks passed
@memsharded memsharded deleted the feature/lockfiles_new branch Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants