move frontend_js under assets #814

Closed
mfrederickson opened this Issue Jan 13, 2014 · 5 comments

Comments

Projects
None yet
3 participants
Member

mfrederickson commented Jan 13, 2014

Sprockets, according to the Gemfile.lock is now at 2.2.2, and the frontend_js directory has a readme.md that states:

This directory should be moved to app/assets/javascripts/frontend, but right now sprockets doesn't let us not exclude it from being bundled in the application. This is fixed in Sprockets 2.2.0, which will hopefully be in use at some point before we release Concerto 2.

Owner

augustf commented Jan 13, 2014

I notice that we have a app/assets/javascripts/frontend directory now with screen_setup.js. Can we mix that with the contents of frontend_js?

Owner

bamnet commented Jan 16, 2014

I don't think screen_setup.js should be mixed with "frontend" because it's not part of the frontend package that we build. The frontend needs a clean directory untouched by the asset pipeline somewhere for the build scripts, if that can be under the app/assets/javascripts directory that's cool.

Owner

augustf commented Jan 25, 2014

@mfrederickson So I randomly gave this a try and my whole app silently failed. Do we need to pass something special to Sprockets to prevent it from bundling the frontend_js?

@ghost ghost assigned mfrederickson Jan 25, 2014

Member

mfrederickson commented Jan 25, 2014

Probably, but I have no idea. This was spurred by a comment that bamnet
had made months ago.

@ghost ghost assigned bamnet Jan 25, 2014

@augustf augustf modified the milestones: 2.1.1, Concerto 2.2 (Frontend) Sep 27, 2014

@augustf augustf modified the milestone: Concerto 2.3 (Frontend) Nov 26, 2014

Owner

augustf commented Apr 1, 2015

#1078 should obsolete this.

@augustf augustf closed this Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment