Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

move frontend_js under assets #814

Closed
mfrederickson opened this Issue · 5 comments

3 participants

@mfrederickson
Collaborator

Sprockets, according to the Gemfile.lock is now at 2.2.2, and the frontend_js directory has a readme.md that states:

This directory should be moved to app/assets/javascripts/frontend, but right now sprockets doesn't let us not exclude it from being bundled in the application. This is fixed in Sprockets 2.2.0, which will hopefully be in use at some point before we release Concerto 2.

@augustf
Owner

I notice that we have a app/assets/javascripts/frontend directory now with screen_setup.js. Can we mix that with the contents of frontend_js?

@bamnet
Owner

I don't think screen_setup.js should be mixed with "frontend" because it's not part of the frontend package that we build. The frontend needs a clean directory untouched by the asset pipeline somewhere for the build scripts, if that can be under the app/assets/javascripts directory that's cool.

@augustf
Owner

@mfrederickson So I randomly gave this a try and my whole app silently failed. Do we need to pass something special to Sprockets to prevent it from bundling the frontend_js?

@mfrederickson
Collaborator
@bamnet bamnet was assigned
@augustf augustf modified the milestone: Concerto 2.3 (Frontend)
@augustf
Owner

#1078 should obsolete this.

@augustf augustf closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.