turbolinks preventing div.inset's background image from loading? #848

Closed
mfrederickson opened this Issue Jan 22, 2014 · 11 comments

Projects

None yet

7 participants

@mfrederickson
Member

It appears that when you go to the screen#show page that the background image of the template is not loading-- but if you refresh the page, it does load. Possibly a turbolinks problem?

before refresh
image

image
These previews are from the concerto_template_scheduling plugin sidebar. Looks like the main template preview is never being loaded (like it is below).

after refresh
image

image
This preview is loaded when you refresh the page

@brzaik brzaik was assigned Jan 22, 2014
@bamnet
Member
bamnet commented Jan 22, 2014

I've been pretending that only I've seen this bug for a few months. I agree with your analysis, turbolinks and background-image doesn't play well for an unknown reason.

@zr2d2
Member
zr2d2 commented Jan 22, 2014

I'm seeing that the image was loaded (albeit from cache), but isn't displaying. Could still be a js problem
screen shot 2014-01-22 at 2 21 39 pm

@zr2d2 zr2d2 added a commit that referenced this issue Jan 28, 2014
@zr2d2 zr2d2 Merge branch 'refs/heads/master' into travis_dbs
* refs/heads/master:
  add hook for content overriding
  only catch MissingTemplate exceptions
  only include key if available
  Disable turbolinks from screens#index to screens#show as a workaround for #848.
  pa should handle activity from plugins
  Round resize calculations up, close #862.
  Only render 404 for single-object model based pages per #857.
449cb0e
@augustf augustf added this to the 0.9.0 KiloBalrog milestone Feb 25, 2014
@bamnet bamnet removed this from the 0.9.0 KiloBalrog milestone Feb 26, 2014
@augustf augustf added this to the 0.9.1 milestone Apr 4, 2014
@augustf
Member
augustf commented Apr 4, 2014

I still notice that the background is blank at first load, but after a few seconds, everything does seem to load.

@mfrederickson
Member

Click Screens button, you'll see the preview of the template. Click Edit
Screen (header button on right). Click cancel. Now you're back on the
Screen page, but the template preview is blank.

On Fri, Apr 4, 2014 at 2:04 PM, August notifications@github.com wrote:

I still notice that the background is blank at first load, but after a few
seconds, everything does seem to load.

Reply to this email directly or view it on GitHubhttps://github.com/concerto/concerto/issues/848#issuecomment-39616296
.

@augustf
Member
augustf commented Apr 4, 2014

No-that's not happening to me. The first time I loaded up screen#show, there was that delay, but now when I go through and click Cancel, there's no problem at all.

@glaszig
glaszig commented Apr 13, 2014

FWIW: I've had a similar problem on Starve where the feed icons would not appear after browsing through the app (which uses turbolink). Using absolute url's to the images appears to be a good workaround as outlined in this SO.

@bamnet bamnet added this to the Concerto 2.0 milestone Apr 26, 2014
@zr2d2 zr2d2 was assigned by augustf Apr 27, 2014
@khanh
Member
khanh commented Apr 28, 2014

I attempted to do this on a brand new workspace, and I could not experience it based on what marvin suggested

@augustf augustf removed this from the Concerto 2.0 milestone Apr 28, 2014
@zr2d2 zr2d2 was unassigned by augustf Apr 28, 2014
@augustf
Member
augustf commented May 19, 2014

Can anyone reproduce this on the master branch?

@mfrederickson
Member

I can check tomorrow.

On May 18, 2014, at 8:34 PM, August notifications@github.com wrote:

Can anyone reproduce this on the master branch?


Reply to this email directly or view it on
GitHubhttps://github.com/concerto/concerto/issues/848#issuecomment-43465449
.

@mfrederickson
Member

This test still shows that it is not loading as it should:
Click Screens button, you'll see the preview of the template. Click Edit
Screen (header button on right). Click cancel. Now you're back on the
Screen page, but the template preview is blank. (If you click update instead, it causes a page reload and it appears fine.)
image

@mfrederickson
Member

This appears to be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment