Frontend fetching deleted RSS content #891

Closed
gbprz opened this Issue Feb 26, 2014 · 10 comments

Comments

Projects
None yet
5 participants
@gbprz
Member

gbprz commented Feb 26, 2014

Earlier today I tried deleting a few graphics from a test feed and suddenly the screen's graphics field stopped showing content. The frontend debug window gave a 404 error when the corresponding field tried to fetch new content. Refreshing the page still gives the same error, as does closing and reopening the browser. Using incognito mode was the only way for the frontend to work again and show new graphics that I was adding to the same feed.

@augustf augustf added this to the 0.9.1 milestone Apr 4, 2014

@augustf

This comment has been minimized.

Show comment Hide comment
@augustf

augustf Apr 4, 2014

Owner

@gabe283 As of our current code, I tried to reproduce this and couldn't. Can you?

Owner

augustf commented Apr 4, 2014

@gabe283 As of our current code, I tried to reproduce this and couldn't. Can you?

@mfrederickson

This comment has been minimized.

Show comment Hide comment
@mfrederickson

mfrederickson Apr 4, 2014

Member

This has happened to me also (and not just with rss stuff being purged).
@august what steps are you performing to test this? Add an rss feed.
Open a preview screen in another window, go back to the app window, and
purge the children from the rss feed. The screen preview window now shows
404's in the console.

On Fri, Apr 4, 2014 at 2:00 PM, August notifications@github.com wrote:

@gabe283 https://github.com/gabe283 As of our current code, I tried to
reproduce this and couldn't. Can you?

Reply to this email directly or view it on GitHubhttps://github.com/concerto/concerto/issues/891#issuecomment-39615958
.

Member

mfrederickson commented Apr 4, 2014

This has happened to me also (and not just with rss stuff being purged).
@august what steps are you performing to test this? Add an rss feed.
Open a preview screen in another window, go back to the app window, and
purge the children from the rss feed. The screen preview window now shows
404's in the console.

On Fri, Apr 4, 2014 at 2:00 PM, August notifications@github.com wrote:

@gabe283 https://github.com/gabe283 As of our current code, I tried to
reproduce this and couldn't. Can you?

Reply to this email directly or view it on GitHubhttps://github.com/concerto/concerto/issues/891#issuecomment-39615958
.

@augustf

This comment has been minimized.

Show comment Hide comment
@augustf

augustf Apr 4, 2014

Owner

Well @gabe283 specified graphics, so I went with that. I'm not familiar with the RSS workflow, but I'll give that a go as well.

Owner

augustf commented Apr 4, 2014

Well @gabe283 specified graphics, so I went with that. I'm not familiar with the RSS workflow, but I'll give that a go as well.

@augustf

This comment has been minimized.

Show comment Hide comment
@augustf

augustf Apr 4, 2014

Owner

I added the Slashdot RSS feed, opened both preview and frontend windows, and then purged the children from it. After doing that, I noticed no change. The content continued to show in both instances, but there were no 404's on the console.

Owner

augustf commented Apr 4, 2014

I added the Slashdot RSS feed, opened both preview and frontend windows, and then purged the children from it. After doing that, I noticed no change. The content continued to show in both instances, but there were no 404's on the console.

@mfrederickson

This comment has been minimized.

Show comment Hide comment
@mfrederickson

mfrederickson Apr 5, 2014

Member

I was using chrome and had the developer area open (with the setting "don't
cache when open" turned on).

On Fri, Apr 4, 2014 at 2:40 PM, August notifications@github.com wrote:

I added the Slashdot RSS feed, opened both preview and frontend windows,
and then purged the children from it. After doing that, I noticed no
change. The content continued to show in both instances, but there were no
404's on the console.

Reply to this email directly or view it on GitHubhttps://github.com/concerto/concerto/issues/891#issuecomment-39618637
.

Member

mfrederickson commented Apr 5, 2014

I was using chrome and had the developer area open (with the setting "don't
cache when open" turned on).

On Fri, Apr 4, 2014 at 2:40 PM, August notifications@github.com wrote:

I added the Slashdot RSS feed, opened both preview and frontend windows,
and then purged the children from it. After doing that, I noticed no
change. The content continued to show in both instances, but there were no
404's on the console.

Reply to this email directly or view it on GitHubhttps://github.com/concerto/concerto/issues/891#issuecomment-39618637
.

@augustf

This comment has been minimized.

Show comment Hide comment
@augustf

augustf Apr 5, 2014

Owner

I see it now. In particular, the error for my RSS feed reads:
ActiveRecord::RecordNotFound in Frontend::ContentsController#index

Couldn't find Content with id=15 [WHERE "contents"."type" IN ('Ticker', 'Graphic', 'HtmlText', 'DynamicContent', 'RemoteVideo', 'Iframe', 'SimpleRss', 'Weather', 'Calendar')]

Owner

augustf commented Apr 5, 2014

I see it now. In particular, the error for my RSS feed reads:
ActiveRecord::RecordNotFound in Frontend::ContentsController#index

Couldn't find Content with id=15 [WHERE "contents"."type" IN ('Ticker', 'Graphic', 'HtmlText', 'DynamicContent', 'RemoteVideo', 'Iframe', 'SimpleRss', 'Weather', 'Calendar')]

@augustf

This comment has been minimized.

Show comment Hide comment
@augustf

augustf Apr 5, 2014

Owner

Steps to Reproduce:

  1. Use Chrome developer tools on network pane with "Disable cache (while DevTools is open)" option
  2. Add some RSS content to a feed a screen is subscribed to
  3. Go to the screen show page and preview the screen (or load the frontend)
  4. Go to the RSS content page and purge the children of the RSS content
  5. 404's should begin showing up in the console of the frontend
Owner

augustf commented Apr 5, 2014

Steps to Reproduce:

  1. Use Chrome developer tools on network pane with "Disable cache (while DevTools is open)" option
  2. Add some RSS content to a feed a screen is subscribed to
  3. Go to the screen show page and preview the screen (or load the frontend)
  4. Go to the RSS content page and purge the children of the RSS content
  5. 404's should begin showing up in the console of the frontend

@bamnet bamnet added this to the Concerto 2.0 milestone Apr 26, 2014

@augustf augustf assigned tyrantkhan and unassigned bamnet May 13, 2014

@augustf augustf changed the title from Frontend fetching deleted content to Frontend fetching deleted RSS content May 17, 2014

@augustf augustf assigned augustf and unassigned tyrantkhan May 18, 2014

@bamnet

This comment has been minimized.

Show comment Hide comment
@bamnet

bamnet May 18, 2014

Owner

I suspect what's going on here is that the content is being deleted but the id is still referenced in the frontend's content timeline. We should make sure that the frontend handles 404's gracefully and moves on to the next piece of content immediately which would be on par with V1 behavior.

Owner

bamnet commented May 18, 2014

I suspect what's going on here is that the content is being deleted but the id is still referenced in the frontend's content timeline. We should make sure that the frontend handles 404's gracefully and moves on to the next piece of content immediately which would be on par with V1 behavior.

@augustf

This comment has been minimized.

Show comment Hide comment
@augustf

augustf May 18, 2014

Owner

I'd tend to agree, except that in Gabe's attempts to reproduce, Graphics don't do this when deleted.

Owner

augustf commented May 18, 2014

I'd tend to agree, except that in Gabe's attempts to reproduce, Graphics don't do this when deleted.

@augustf

This comment has been minimized.

Show comment Hide comment
@augustf

augustf May 18, 2014

Owner

Could that be because RSS URL's get handled differently on the backend?

Owner

augustf commented May 18, 2014

Could that be because RSS URL's get handled differently on the backend?

tyrantkhan added a commit that referenced this issue May 19, 2014

Closes #891.. Thanks @gabe283 thanks for finding this.
Let the record reflect that Haris found this commit to be particularly frustrating.

zr2d2 added a commit that referenced this issue May 23, 2014

Merge branch 'master' into rails-4
* master: (33 commits)
  add french translation from Lucas Manssens
  General bundle update in keeping with #930 and the 1.8.x deprecation. The only restrictions left are for rails and Rubyzip (not sure why). Let's hope Generalissimo Travis approves of this little putsch
  rename variable and use clearer conditional
  fix feed visibility
  display group owned screen in my screens
  fix screen permission (don't show all screens in other section)
  Closes #924. Another Devilish Bug Vanquished.
  submissions#show issue where 'edit content' would block link
  #869 handle no files edits
  #869 support replacing graphic and stylesheet on template edit
  #869 add fields for graphic and stylesheet files
  Bump to 0.9.1.kilobalrog.
  Fixes #923 thanks for the hint @bamnet
  Disable viewport scaling for mobile devices
  changed responsiveness of menu per #521. it's not perfect, but it's a start without going crazy over mobile use
  fixed the attribution of the commit. sorry for being a concerto virgin...
  Revert "added "edit content" and some flashy jquery to actually do it"
  added "edit content" and some flashy jquery to actually do it
  Proper logging for Content Not Found for Frontend
  Closes #891.. Thanks @gabe283 thanks for finding this.
  ...

Conflicts:
	Gemfile
	Gemfile.lock

zr2d2 added a commit that referenced this issue May 30, 2014

Merge branch 'master' into attribute_names
* master: (33 commits)
  add french translation from Lucas Manssens
  General bundle update in keeping with #930 and the 1.8.x deprecation. The only restrictions left are for rails and Rubyzip (not sure why). Let's hope Generalissimo Travis approves of this little putsch
  rename variable and use clearer conditional
  fix feed visibility
  display group owned screen in my screens
  fix screen permission (don't show all screens in other section)
  Closes #924. Another Devilish Bug Vanquished.
  submissions#show issue where 'edit content' would block link
  #869 handle no files edits
  #869 support replacing graphic and stylesheet on template edit
  #869 add fields for graphic and stylesheet files
  Bump to 0.9.1.kilobalrog.
  Fixes #923 thanks for the hint @bamnet
  Disable viewport scaling for mobile devices
  changed responsiveness of menu per #521. it's not perfect, but it's a start without going crazy over mobile use
  fixed the attribution of the commit. sorry for being a concerto virgin...
  Revert "added "edit content" and some flashy jquery to actually do it"
  added "edit content" and some flashy jquery to actually do it
  Proper logging for Content Not Found for Frontend
  Closes #891.. Thanks @gabe283 thanks for finding this.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment