Group#show user dependecies

[bamnet]

The group show page seems to require a) a user to be logged in and b) that user to be a member of the current group. Zach's having trouble reproducing this error locally, but it occurs in the nightly instance.

[augustf]

I noticed that in groups#show, current_user is called in a Finder. This will break if someone isn't logged in. We could do some checking and show them an empty page. But anonymous web users have no real reason to see Groups anyway. If there's no objection, I'm going to require a persisted user permission to see groups.

[bamnet]

That current_user call will fix half of the problem, but you'll still get errors later on (@membership may be nil if you're not a member of the group).

Anonymous users need be able to see a group in order to get in touch with a public screen's owner, don't they?

[augustf]

Well in the current UI, I don't see any way for a non-logged-in user to see a screen or its owners...

Also looking at the other half of the issue now...

[bamnet]

I think our menu's may be a bit stripped down... I imagine folks seeing a screen in public can somehow navigate to a page that describes the content being shown on that screen and who runs it. We were often the sole point of contact for screens @ RPI because it wasn't easy / clear enough who was in charge of them.

[augustf]

Fair enough - a current_user check should suffice then, though I'll have to get past the other error to verify...