Sanitize keys before confirmation modal. #1558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Without sanitization, these are susceptible to an varying degrees of XSS attack depending on the input. When the values are displayed in the twitter-bootstrap-confirmation modal (I don't fully understand how it works) the JS is rendered and executed. The
user.namefields are the most concerning for instances that allow public registration, but we sanitize everywhere this pattern is used to be safe.Kudos to Ben Shaw (@sudonoodle) for finding this vulnerability!