New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version to image_resource #190

Merged
merged 1 commit into from Aug 11, 2017

Conversation

Projects
None yet
4 participants
@krishicks
Contributor

krishicks commented Aug 7, 2017

I haven't tested this; I made these changes based on the addition of params to image_resource, which seems more complicated than adding version.

The reason for wanting this is basically what it says on the tin: so we can pin a specific version of the resource that's used for image_resource.

In the particular use case I have in mind for this feature, we have an S3 bucket being used to supply the rootfs for the task. We also need to bless particular combinations of versions, down to the rootfs, to ensure they work together. This feature gives us the ability to pin not just the normal resource gets but the image_resource rootfs as well.

Kris Hicks

@topherbullock topherbullock added this to the v3.4.x milestone Aug 8, 2017

@mhuangpivotal mhuangpivotal merged commit cf569c7 into concourse:master Aug 11, 2017

2 checks passed

ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
concourse-ci/status Concourse CI build success
Details

mhuangpivotal added a commit to concourse/testflight that referenced this pull request Aug 11, 2017

Add a test for image_resource version
concourse/atc#190

Signed-off-by: JT Archie <jtarchie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment