This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
Add a dogstatsd metric emitter #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptiste-bonnaudet
force-pushed
the
master
branch
from
1588f54
to
9bad856
Compare
Signed-off-by: baptiste-bonnaudet <baptiste.bonnaudet@lightspeedhq.com>
baptiste-bonnaudet
force-pushed
the
master
branch
from
9bad856
to
e3466af
Compare
vito
suggested changes
Apr 22, 2018
metric/emitter/dogstatsd.go
Outdated
|
|
||
| func (emitter *DogstatsdEmitter) Emit(logger lager.Logger, event metric.Event) { | ||
|
|
||
| reg, _ := regexp.Compile("[^a-zA-Z0-9_]+") |
There was a problem hiding this comment.
May be better to do this outside of Emit so it's only compiled once. You could use regexp.MustCompile too.
Something like:
var specialChars = regexp.MustCompile(...)
func (emitter *DogstatsdEmitter) Emit(logger lager.Logger, event metric.Event) {
metric/emitter/dogstatsd.go
Outdated
| } else if f, ok := event.Value.(float64); ok { | ||
| value = f | ||
| } else { | ||
| logger.Error(fmt.Sprintf("failed-to-convert-metric-for-dogstatsd: %s", name), nil) |
There was a problem hiding this comment.
Rather than a format string, lager.Data should be used here:
logger.Error("failed-to-convert-metric-for-dogstatsd", nil, lager.Data{
"metric-name": name,
})Signed-off-by: baptiste-bonnaudet <baptiste.bonnaudet@lightspeedhq.com>
|
@vito, thanks for the review! I fixed the requested changes and created the PR for the documentation concourse/docs#54 |
wendorf
added a commit
to wendorf/charts
that referenced
this pull request
May 24, 2018
Concourse 3.13.0 adds support for exporting metrics to Datadog (see vmware-archive/atc#269). This adds support for the new flags, and bumps the Concourse version.
wendorf
pushed a commit
to opendoor-labs/charts
that referenced
this pull request
May 24, 2018
Concourse 3.13.0 adds support for exporting metrics to Datadog (see vmware-archive/atc#269). This adds support for the new flags, and bumps the Concourse version. NOTE: This is a modification to helm#5650 and should be removed when that is merged. Usage of this fork will also need to be updated to match the changed key names.
k8s-ci-robot
pushed a commit
to helm/charts
that referenced
this pull request
May 30, 2018
Concourse 3.13.0 adds support for exporting metrics to Datadog (see vmware-archive/atc#269). This adds support for the new flags, and bumps the Concourse version.
or1can
pushed a commit
to or1can/charts
that referenced
this pull request
Jul 10, 2018
Concourse 3.13.0 adds support for exporting metrics to Datadog (see vmware-archive/atc#269). This adds support for the new flags, and bumps the Concourse version.
voron
pushed a commit
to dysnix/helm-charts
that referenced
this pull request
Sep 5, 2018
Concourse 3.13.0 adds support for exporting metrics to Datadog (see vmware-archive/atc#269). This adds support for the new flags, and bumps the Concourse version. Signed-off-by: voron <av@arilot.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows direct integration with Datadog using statsd agent.
Adds new configuration flags for atc: