Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Dashboard header doesn't stick on mobile resolution #2434
Capturing the conversation @pivotal-jamie-klassen and I had about a more elegant solution to the mobile view top navigation bar.
Because the top navigation bar is increasing in height, in the current implementation, this is causing problems with the logout and sticky team name feature. If we can better arrange the elements in the top nav to better accommodate the search input and log out/in button we can reduce the amount of chrome and users can better view their pipeline thumbnails with more height now available.
added a commit
Oct 5, 2018
@Lindsayauchin the only edge case I have not covered (and it is a somewhat exotic one) is this:
when you are in the mobile view and the search bar is collapsed (the first screenshot above), the keyboard shortcut for search (
I consider this exotic because you are generally not relying on keyboard shortcuts at the mobile view. @jama-pivotal does this strike you as reasonable?
Either way, if this feature is desirable, let's maybe put it in a different story? I've added a ton of tests as part of this work and it's going to help with some single source of truth refactors down the line. once the