Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No results found text not properly aligned when page is scrolled #2435

Closed
jama22 opened this Issue Jul 30, 2018 · 1 comment

Comments

Projects
4 participants
@jama22
Copy link
Member

jama22 commented Jul 30, 2018

There are specific steps to reproduce:

  1. Load the dashboard (any resolution) https://ci.concourse-ci.org/
  2. Scroll so that the team name stickies
  3. Search for something with no users found

This is what happens:

screen shot 2018-07-30 at 10 08 32 am

@jama22 jama22 created this issue from a note in UX (Backlog: Web) Jul 30, 2018

@jama22 jama22 added the size/medium label Aug 20, 2018

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

pivotal-jamie-klassen commented Oct 18, 2018

this is really tough to test and prevent regressions (we'll need some more sophisticated assertions in watsjs, someday), but did in fact get fixed as a consequence of our hand-rolled sticky header solution in #2430.

@pivotal-jamie-klassen pivotal-jamie-klassen moved this from Backlog: Web to Done in UX Oct 18, 2018

@jama22 jama22 added the accepted label Nov 19, 2018

@jama22 jama22 closed this Nov 19, 2018

@vito vito added this to the v5.0.0 milestone Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.