Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of sidebar for pipeline groups makes navigation difficult #2440

Closed
mcwumbly opened this issue Jul 30, 2018 · 9 comments · Fixed by #3829

Comments

@mcwumbly
Copy link

@mcwumbly mcwumbly commented Jul 30, 2018

Hi there!

Feature Request

What challenge are you facing?

Our team uses concourse heavily. We currently have 41 pipelines (and that's after removing a number of them recently). We regularly have to monitor several of these pipelines concurrently, as we are responsible for regularly shipping patches to 4 versions of 4 products. Each of these pipelines are large. For example, here's a typical one (of these 41) pipelines that has ~80 jobs split into ~10 pipeline groups:

one-pipeline

ten-groups

Before, upgrading to 4.0, there was a sidebar with our ~40 pipelines so when we were viewing one, we could relatively easily navigate to another. Now, we have to go back and forth to the dashboard, which is much more cumbersome.

Using high density mode does make things a little better, but it still requires one to go back and forth quite a bit, or to keep a tab open and remember to open new pipelines in new tabs...

A Modest Proposal

Please bring back the persistent sidebar menu in some form so that we can navigate from one pipeline to another with a single click, regardless of where we are in the hierarchy of the UI.

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Apr 10, 2019

@vito @mcwumbly @pivotal-jamie-klassen

  • The list can be vertically scrolled independently of the rest of the screen’s content.
  • Sidebar starts at the same level as the content below the top app bar and the sidebar will push the content to the right (not on top of the content as some users like to keep the sidebar expanded at all times.
  • Pipelines will be grouped by team
  • Toggling a chevron icon on the left of the team name expands the list of pipelines for that team. This expanded list of pipelines remains persistent to the user.
  • Team icon will appear beside the team names
  • Pipeline icon appears beside the pipeline the use is currently in
  • Hover state on list will follow the UI style used for the groups bar on the pipeline view.

Bring back the sidebar proposal

Pipeline

Expanded:

Screen Shot 2019-04-15 at 12 18 48 PM
Screen Shot 2019-04-15 at 12 16 06 PM

Collapsed:
Screen Shot 2019-04-15 at 12 09 58 PM

Dashboard

Screen Shot 2019-04-15 at 12 16 06 PM

Build page

Screen Shot 2019-04-15 at 12 30 43 PM

Resource Page

Screen Shot 2019-04-15 at 12 28 34 PM

@mcwumbly

This comment has been minimized.

Copy link
Author

@mcwumbly mcwumbly commented Apr 10, 2019

@Lindsayauchin we use "groups" pretty heavily to keep pipelines organized. Is there any consideration in the design to also group by pipelines by group?

You can browse our pipelines here to get a better sense of our concrete problem: https://releng.ci.cf-app.com/

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Apr 11, 2019

@mcwumbly something like this?

Screen Shot 2019-04-11 at 9 50 30 AM
Chevron would indicate that the pipeline has groups and can be expanded to show them.

Do you think it make sense to display the groups at this level? It could be collapsed away and then the user expands a keeps them persistent.

Thoughts?

@mcwumbly

This comment has been minimized.

Copy link
Author

@mcwumbly mcwumbly commented Apr 11, 2019

Yes, I think that would be helpful for us!

@vito

This comment has been minimized.

Copy link
Member

@vito vito commented Apr 15, 2019

given that i'm viewing a pipeline-scoped page
when the sidebar is open
then the most relevant team/pipeline is expanded

given that i have the sidebar open and some teams expanded,
when i refresh the page
then the sidebar should still be open but all the "irrelevant" teams collapsed.

@vito

This comment has been minimized.

Copy link
Member

@vito vito commented Apr 15, 2019

MVP is no groups in sidebar

@vito

This comment has been minimized.

Copy link
Member

@vito vito commented Apr 15, 2019

@jama22 separate story for status icons on sidebar pipelines

@vito vito added the size/large label Apr 15, 2019
@pivotal-jamie-klassen pivotal-jamie-klassen self-assigned this Apr 16, 2019
pivotal-jamie-klassen added a commit that referenced this issue Apr 16, 2019
#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue Apr 17, 2019
#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue Apr 23, 2019
#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue Apr 23, 2019
#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue Apr 23, 2019
#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue Apr 24, 2019
#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented May 6, 2019

@Lindsayauchin how about tooltips for long team/pipeline names? Might as well get that in before release, as I can imagine some users who consistently have long team names who will find a 275px sidebar unusable.

Also as I play with this feature I find myself craving a keyboard shortcut to toggle the sidebar. @vito

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented May 6, 2019

@pivotal-jamie-klassen
something like this?

Screen Shot 2019-05-06 at 4 22 35 PM

pivotal-jamie-klassen added a commit that referenced this issue May 7, 2019
* reuse hamburgerMenu
* scroll ports include ID of element to scroll

#2440

Signed-off-by: James Thomson <jthomson@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue May 7, 2019
* and notfound
* also fix build page sideways scrolling

#2440

Signed-off-by: James Thomson <jthomson@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue May 7, 2019
* and notfound
* also fix build page sideways scrolling

#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: James Thomson <jthomson@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue May 7, 2019
pivotal-jamie-klassen added a commit that referenced this issue May 7, 2019
#2440

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
@vito vito closed this in #3829 May 8, 2019
@Lindsayauchin Lindsayauchin referenced this issue May 23, 2019
0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.