Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fly set-pipeline after auth prompt loses keystrokes during confirmation prompt #2780

Closed
larham opened this issue Sep 25, 2018 · 3 comments

Comments

@larham
Copy link

@larham larham commented Sep 25, 2018

Using fly 3.14.1, and some previous versions we think, we notice that keystrokes seem to be lost by the fly app.

Steps:

  • fly logout
  • fly sp
  • authenticate using browser
  • It shows a diff of changes to pipeline, and then asks apply configuration? [yN]:
  • type some characters

Expected:

  • each and every character is echoed on command line and functions

Actual:

  • it seems like every other character is swallowed, or one character out of several is accepted

Example

In the example below, we typed 123456789123456789123456789 at the prompt (very rapidly, by swiping across the keys). Only a few of those characters were echoed to the screen.

→ fly -t prod set-pipeline -p [...] -c [...] -l [...]
could not find a valid token.
logging in to team 'main'

1: GitHub
2: Basic Auth
choose an auth method: 1

navigate to the following URL in your browser:

    https://prod.ci.gpdb.pivotal.io/auth/github?team_name=main&fly_local_port=49934

or enter token manually:
token must be of the format 'TYPE VALUE', e.g. 'Bearer ...'
or enter token manually: target saved
jobs:
  job demo has been added:
+ name: demo
+ plan:
+ - task: hello world
+   config:
+     platform: linux
+     run:
+       path: bash
+       args:
+       - -c
+       - echo hello world
+   image: bash

apply configuration? [yN]: 369251379

CC: @dsharp-pivotal

@dsharp-pivotal

This comment has been minimized.

Copy link

@dsharp-pivotal dsharp-pivotal commented Sep 28, 2018

I noticed today it's not just the "apply configuration" prompt. It also happens when fly intercept requires a login, so it appears to be related to the login.

@Typositoire

This comment has been minimized.

Copy link

@Typositoire Typositoire commented Oct 1, 2018

We are also experiencing this. It has to do with login because it's happens when you issue a cmd then get redirected to login and back to your cmd.

@vito vito transferred this issue from concourse/fly Nov 12, 2018
@jama22 jama22 added bug fly labels Nov 12, 2018
@jama22

This comment has been minimized.

Copy link
Member

@jama22 jama22 commented Nov 12, 2018

Linking to #2414 because its the same root cause

@jama22 jama22 added the accepted label Dec 10, 2018
@jama22 jama22 closed this Dec 10, 2018
@vito vito added this to the v5.0.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.