Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard team labels updated to display User Role #2843

Closed
jama22 opened this issue Nov 21, 2018 · 5 comments

Comments

@jama22
Copy link
Member

@jama22 jama22 commented Nov 21, 2018

In Concourse 4.0 - 4.2.1, the Concourse Dashboard indicates to you whether you are a member of a team or whether the pipelines you are seeing on a team is because of an exposed pipeline:

screen_shot_2018-11-21_at_1_59_17_pm

Proposal

With the completion of RBC concourse/rfcs#6 , it would be nice for Concourse now to show you specifically what role you have against a team. Instead of simply MEMBER it should show pills for the roles you have on that team e.g. VIEWER, MEMBER, or OWNER.

Designs

cc @Lindsayauchin for design help

@jama22

This comment has been minimized.

Copy link
Member Author

@jama22 jama22 commented Nov 26, 2018

In the scenario where you can see a team and not be a member of it, use no label:

  • you are admin and can see all teams, but not their pipelines
  • you are looking at an exposed pipeline
@jama22 jama22 added the size/medium label Nov 26, 2018
@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Nov 26, 2018

screen shot 2018-11-26 at 3 52 48 pm

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Nov 27, 2018

only show the "biggest" role the user has for each team: e.g. if /sky/userinfo reports that a user has both the owner and viewer roles for team A, only show an owner pill on that team.

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Nov 27, 2018

In the interest on maintaining a single source of truth about RBAC, we are introducing a change to the userinfo endpoint such that the array of roles for each team will be sorted in decreasing order.

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Nov 27, 2018

In previous stories about the order in which to display teams on the dashboard, we had decided to show teams you are a member of first, followed by teams that you are only seeing because of exposed pipelines. We're going to assume here that in this story, the requirement is to sort teams on the dashboard according to your role:

  1. owner
  2. member
  3. viewer
  4. teams you are only seeing because of exposed pipelines, or because you are an admin.

@jama-pivotal please complain if this is bad.

xtremerui added a commit that referenced this issue Nov 27, 2018
#2843

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
xtremerui added a commit that referenced this issue Nov 27, 2018
pivotal-jamie-klassen added a commit that referenced this issue Nov 28, 2018
and make them more specific (single point of failure)

#2843

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
@jama22 jama22 added the accepted label Dec 3, 2018
@jama22 jama22 closed this Dec 3, 2018
@vito vito added this to the v5.0.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.