Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Exposed Pipeline state should be on the pipeline #2844

Closed
jama22 opened this issue Nov 21, 2018 · 3 comments

Comments

@jama22
Copy link
Member

@jama22 jama22 commented Nov 21, 2018

Starting from Concourse 4.2.0 we started showing EXPOSED on teams when you were seeing pipelines/teams because another team exposed that pipeline:

screen shot 2018-11-21 at 2 30 23 pm

This was done so that users can distinguish between pipelines they can access because they are members vs exposed pipelines where they have limited access.

Proposal

The enhancement we are proposing is to push the iconography of "exposed" onto the pipeline thumbnail itself. This would help team owners who have already exposed pipelines to visually identify which pipelines have already been exposed

This is somewhat linked to #2843 in that the design changes will be intertwined

Design

cc @Lindsayauchin for design help

@jama22 jama22 changed the title Dashboard Exposed Pipeline design change Dashboard Exposed Pipeline state should be on the pipeline Nov 21, 2018
@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Nov 26, 2018

screen shot 2018-11-26 at 3 51 06 pm 1
Assets:
eye_icon.zip

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Nov 28, 2018

@Lindsayauchin currently there are two horizontal dividing lines on a pipeline card -- one near the top between the header and the preview, and the other near the bottom between the between the footer and the preview. These mockups only show the top dividing line. Should we remove the lower dividing line as part of this story?

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Nov 28, 2018

my mistake! I was using an older mock. Updated the screen to our changes made as per our conversation with James.

screen shot 2018-11-28 at 4 55 59 pm

pivotal-jamie-klassen added a commit that referenced this issue Nov 28, 2018
converted some more CSS to inline styles,
extracted common Msgs module for Dashboard stuff

#2844

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
@jama22 jama22 added the accepted label Dec 3, 2018
@jama22 jama22 closed this Dec 3, 2018
@jama22 jama22 closed this Dec 3, 2018
@vito vito added this to the v5.0.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.