Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to unpin a resource version from the top bar in Concourse 5.0.0 #2870

Closed
clarafu opened this issue Nov 26, 2018 · 3 comments

Comments

@clarafu
Copy link
Contributor

@clarafu clarafu commented Nov 26, 2018

Within the 5.0.0 release, pausing of resources will be removed and replaced with a pinned resource to the most recent version. When a user upgrades to 5.0, we want to ensure that their paused resources do not get checked (for cases where users that paused their resource in order to make sure that certain jobs do not get triggered) by pinning the previously paused resource to the latest version before the migration. This will mean that the api_pinned_version column will contain the latest version of the resource after the migration, but no versions would exist yet within the resource_config_versions table. In the case where the resource is unique (meaning that the resource is the only one pointing to a specific resource config), the resource config will never be checked. Currently, the only way to unpin a version is to click on the unpin button on that specific resource version, and in this case where no versions will ever exist there will be no way to unpin the resource.

There are a few proposals:

  • Display a message saying something along the lines of "There are no versions for this resource but if you want to unpin it, use fly unpin-resource. Also we would need to add a fly unpin-resource.
  • Add a button to the pin-bar for unpinning the resource no matter if the version exists
  • For the future: Add a "concourse" comment says a message about using fly unpin resource to un pin this version (this relies on the commenting on pinning versions issue to be finished)
@clarafu clarafu added this to the v5.0.0 milestone Nov 26, 2018
@jama22

This comment has been minimized.

Copy link
Member

@jama22 jama22 commented Nov 27, 2018

Cross-referencing to the UX and Design backlogs. After some discussion we agree that pinning the paused resource is the best recourse for the upgrade. This leaves the question of what the best way to communicate to users that we did this.

We are leaning towards doing pin messaging, where we would default the pin action with a "system user" message saying "hey, we pinned this for you as a part of upgrading". This has the side effect of us implementing the first version of resource commenting.. <- J/K that's another issue and unrelated

The immediate solution to this is to let users pin/unpin from the pin bar so they can resume their resource
screen_shot_2018-11-27_at_11_43_59_am

@jama22 jama22 changed the title Upgrading to 5.0.0 with paused resources could result in a unrecoverable state Allow users to unpin a resource version from the top bar in Concourse 5.0.0 Nov 27, 2018
@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Nov 28, 2018

@Lindsayauchin I'm going to assume that showing a pointer cursor when mousing over the active pin bar is enough indication that it has an associated action -- starting this story now, but if you decide you want some more obvious hover state let me know.

Also after discussing with @jama-pivotal, we decided the unpin action should occur only when you click the actual pin icon inside the pin bar, to avoid unpinning by accident. Mobile users in particular are at risk of errant click events, and accidentally unpinning a resource is potentially expensive/frustrating/confusing.

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Nov 28, 2018

Pointer cursor is great. Could we add a darker background behind the pin icon to the hover state?
screen shot 2018-11-28 at 12 39 05 pm
screen shot 2018-11-28 at 12 38 46 pm

pivotal-jamie-klassen added a commit that referenced this issue Nov 28, 2018
#2870

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
@jama22 jama22 added the accepted label Dec 10, 2018
@jama22 jama22 closed this Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.