Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fly output of user / role info should be displayed in owner, member, viewer order #2880

Closed
jama22 opened this issue Nov 28, 2018 · 1 comment
Closed

Comments

@jama22
Copy link
Member

@jama22 jama22 commented Nov 28, 2018

With the introduction of RBAC and roles, there are two scenarios where the user information is shown to the user through fly: teams -d and set-team. The information in both scenarios are listed in lexical ordering. For example:

===================
fly -t ci set-team -n team1 -c ./config.yml

Team Name: team1

Users (member):
- local:member1

Groups (member):
- none

Users (owner):
- local:owner1

Groups (owner):
- none

Users (viewer):
- local:viewer1

Groups (viewer):
- none
========================
fly -t ci teams -d

name          users          groups
main/owner    local:test     none  
team1/member  local:member1  none  
team1/owner   local:owner1   none  
team1/viewer  local:viewer1  none  

In both situations I would have expected Owners to be listed first, then Member, then Viewer:

for fly set-team:


Users (owner):
- local:owner1

Groups (owner):
- none

Users (member):
- local:member1

Groups (member):
- none

Users (viewer):
- local:viewer1

Groups (viewer):
- none

and for fly teams -d:

name          users          groups
main/owner    local:test     none  
team1/owner   local:owner1   none  
team1/member  local:member1  none  
team1/viewer  local:viewer1  none  
@jama22

This comment has been minimized.

Copy link
Member Author

@jama22 jama22 commented Dec 3, 2018

Rejecting, because the output is now

name          users          groups
main/owner    local:test     none  
team1/owner   local:owner1   none  
test1/owner   local:owner1   none  
team1/member  local:member1  none  
test1/member  local:member1  none  
team1/viewer  local:viewer1  none  
test1/viewer  local:viewer1  none  

but I would have expected

name          users          groups
main/owner    local:test     none  
team1/owner   local:owner1   none  
team1/member  local:member1  none  
team1/viewer  local:viewer1  none  
test1/owner   local:owner1   none  
test1/member  local:member1  none  
test1/viewer  local:viewer1  none  

To be clear, I'd like team first, then owner/member/viewer

@jama22 jama22 added the rejected label Dec 3, 2018
@jama22 jama22 added accepted and removed rejected labels Dec 10, 2018
@jama22 jama22 closed this Dec 10, 2018
@vito vito added this to the v5.0.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.