Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users should be able to see teams they belong to on the dashboard with no pipelines set #2881

Closed
jama22 opened this issue Nov 28, 2018 · 16 comments

Comments

@jama22
Copy link
Member

@jama22 jama22 commented Nov 28, 2018

Concourse shows me the No Pipelines set screen when I am logged into concourse and none of my teams have pipelines set.

For example, consider that I am logged in as Member1 and I belong to two teams Team1 and Team2 with no pipelines yet. When I log in I get:

screen shot 2018-11-28 at 11 06 28 am

The moment I set a pipeline on Team2 I see:
screen shot 2018-11-28 at 11 09 14 am

Proposal

The lazy solution would be to repeat the second screenshot and have all teams report no pipelines found. But I think we can do better and use the No Pipelines Found, pls download fly screen to list team names that you have the option of working against

cc @Lindsayauchin

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Dec 7, 2018

A user that is logged in and is a member of teams with no set pipeline(s).

dashboard_empty_state_member1_no-pipelines

@jama22

This comment has been minimized.

Copy link
Member Author

@jama22 jama22 commented Dec 10, 2018

text should actually read fly set-pipeline in that mock.

@jama22 jama22 added the size/medium label Dec 10, 2018
@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Dec 10, 2018

A user that is not logged in.

dashboard_empty_state_login_welcome

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Dec 11, 2018

animation_start_screen

Airplane svg asset
airplanes_welcome_ascii.svg.zip

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 11, 2018

@Lindsayauchin @jama-pivotal how about the high-density view?

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 11, 2018

@Lindsayauchin it seems like the big card has a background color that is ever-so-slightly lighter than the pipeline cards. is it ok to use the same color as the pipeline cards?

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 11, 2018

@Lindsayauchin also having trouble reproducing that title font -- looks like you used a lighter weight and increased the letter spacing?

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Dec 11, 2018

@pivotal-jamie-klassen good catch! Somehow I let an old Isoveka font sneak in there.

screen shot 2018-12-11 at 4 58 53 pm

  • "welcome to concourse!" is 32 px
  • body copy is 12 px

Also, use the same color as the pipeline cards background.

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Dec 11, 2018

@pivotal-jamie-klassen Can we disable the legend until a pipeline is set?
So, that there is no path for a user to get to that view until they set pipeline and the legend is then visible? What do you think?
dashboard_empty_state_member1_no-pipelines

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 11, 2018

@Lindsayauchin i think that's a good idea from an implementation perspective (it lets us reuse some of the Hover messages), and it has good design sense because none of the pipeline status indicators will be on the page when there are no pipelines anyway, but people can still navigate directly to /hd.

It's not hard to just show the same view even if they navigate to /hd, if that's really what we want. I guess that's the real question.

PS. While it may make sense not to show the legend, I wouldn't be totally sure we don't want to show the bottom bar at all -- like it might still be useful to see the concourse version in the bottom right, but I wouldn't really defend that.

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 11, 2018

@Lindsayauchin @jama-pivotal also want to confirm that the plan is not to show the search bar when the page is in this state? Consequently I would think you can't filter the list of (empty) teams.

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 12, 2018

  • remove legend from bottom bar and align info section to the right
  • when there are no pipelines, redirect requests to /hd back to /.
@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 12, 2018

@Lindsayauchin

This comment has been minimized.

Copy link
Contributor

@Lindsayauchin Lindsayauchin commented Dec 12, 2018

For animated airplane art

Link to ascii generator: http://picascii.com/
Original plane art: planes.png.zip

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 12, 2018

'welcome to concourse!' - 32px font
'first download...' - 16px font
CLI icons are 32px square
card height is 200px

@pivotal-jamie-klassen

This comment has been minimized.

Copy link
Contributor

@pivotal-jamie-klassen pivotal-jamie-klassen commented Dec 20, 2018

One last narrowing of the scope: the animated background belongs in a separate issue.

@vito vito added this to the v5.0.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.