Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected auth config when some of org/team/user are not provided #2887

Closed
mhuangpivotal opened this issue Nov 29, 2018 · 0 comments
Closed

unexpected auth config when some of org/team/user are not provided #2887

mhuangpivotal opened this issue Nov 29, 2018 · 0 comments

Comments

@mhuangpivotal
Copy link
Contributor

@mhuangpivotal mhuangpivotal commented Nov 29, 2018

When deploying concourse using https://github.com/concourse/concourse-bosh-release
with ops file https://github.com/concourse/concourse-bosh-deployment/blob/master/cluster/operations/github-auth.yml, if the team config is concourse:Pivotal

The file is interpolated into

...
    CONCOURSE_MAIN_TEAM_GITHUB_ORG: ""

    CONCOURSE_MAIN_TEAM_GITHUB_TEAM: "concourse:Pivotal"

    CONCOURSE_MAIN_TEAM_GITHUB_USER: ""
...

The main team auth in DB ended up like

{"owner":{"groups":["github:","github:concourse:pivotal"],"users":["github:","local:secret"]}

The "github:" is a side-effect that should not be there.

expected results:

  1. CONCOURSE_MAIN_TEAM_GITHUB_ORG and CONCOURSE_MAIN_TEAM_GITHUB_USER should not be included if they are empty strings
  2. the main team auth should look like
{"owner":{"groups":["github:concourse:pivotal"],"users":["local:secret"]}
@mhuangpivotal mhuangpivotal added the auth label Nov 29, 2018
@jama22 jama22 added the bug label Dec 3, 2018
mhuangpivotal pushed a commit that referenced this issue Dec 3, 2018
#2887

Signed-off-by: Mark Huang <mhuang@pivotal.io>
@vito vito added the accepted label Jan 2, 2019
@vito vito closed this Jan 2, 2019
@vito vito added this to the v5.0.0 milestone Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.