New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make periodic check container rebalancing duration configurable #2988

Open
vito opened this Issue Jan 3, 2019 · 0 comments

Comments

1 participant
@vito
Copy link
Member

vito commented Jan 3, 2019

see #2923

What challenge are you facing?

Concourse rebalances check containers periodically to make sure they don't all end up one worker after a deploy. The duration that they rebalance is determined by worker uptime (so we rebalance more aggressively if there are newly provisioned workers), with an upper bounds of 1 hour. This upper bound is hardcoded and can result in painful re-cloning of large repos every hour.

What would make this better?

Make it configurable? I could see two schemes here:

  • After some value X (default 1 hour), back off on the rebalancing, only rebalancing after some value Y (configurable, default 1 hour to keep today's behavior).
  • Simply add one value X which is the cap for the rebalancing, the same way the 1 hour configuration works today.

Not sure if one is better or worse, just that if you want to slow down the rebalancing more aggressively you may prefer the first option (otherwise things will keep rebalancing, just slower and slower until it hits your limit, say 24 hours).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment