Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-flag 'global resources' functionality #3013

Closed
vito opened this issue Jan 8, 2019 · 1 comment · Fixed by #3133
Closed

Feature-flag 'global resources' functionality #3013

vito opened this issue Jan 8, 2019 · 1 comment · Fixed by #3133

Comments

@vito
Copy link
Member

@vito vito commented Jan 8, 2019

What challenge are you facing?

Global resources (#2386) is great and all but we're now aware of two different situations where we don't want it: the time resource (to avoid stampeding herd of periodic jobs on workers) and resources that use IAM roles to determine resource access (#3002).

What would make this better?

We should make it opt-in for now until we can more fully understand the impact of this feature and what changes may be necessary in order to make it safe to enable by default.

Most of the work for this is already done in #2908. I'm proposing that we add a flag to the ATC, --enable-global-resources, and have it default to false for now.

If the value is set to false, we should never share version history across resources regardless of whether the resource type configured unique_version_history (per #2908).

As this feature is primarily beneficial to large multi-tenant installations, it can be up to their operator's discretion whether they want to enable the feature or not.

@clarafu

This comment has been minimized.

Copy link
Contributor

@clarafu clarafu commented Jan 18, 2019

Note that the flag only applies to having resources opt-in for sharing resource versions, resource type versions will always be shared even if the flag is applied. We decided to do this because resource type versions are not visible to users (since it pretty much always uses the latest version).

@vito vito closed this in #3133 Jan 29, 2019
Prototypes (Resources v2) automation moved this from Planned to Done Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.