Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature-flag 'global resources' functionality #3013
What challenge are you facing?
Global resources (#2386) is great and all but we're now aware of two different situations where we don't want it: the time resource (to avoid stampeding herd of periodic jobs on workers) and resources that use IAM roles to determine resource access (#3002).
What would make this better?
We should make it opt-in for now until we can more fully understand the impact of this feature and what changes may be necessary in order to make it safe to enable by default.
Most of the work for this is already done in #2908. I'm proposing that we add a flag to the ATC,
If the value is set to
As this feature is primarily beneficial to large multi-tenant installations, it can be up to their operator's discretion whether they want to enable the feature or not.
Note that the flag only applies to having resources opt-in for sharing resource versions, resource type versions will always be shared even if the flag is applied. We decided to do this because resource type versions are not visible to users (since it pretty much always uses the latest version).