Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
USABILITY: Add cyclical pipeline references to validation errors #3053
If you have a cyclical reference in a job, for example:
jobs: - name: my-job plan: - get: some-resource trigger: true passed: [my-job]
You can set the pipeline via
Steps to Reproduce
Create a pipeline with a job that conforms to the passed criteria seen above
Technically this works and does something kind of interesting, though it's unhelpful that the UI detonates.
It means "run with whatever version I last succeeded with". Which is useful if you want to pin something and are too lazy to go see what it is.
...ok, we should probably just forbid it.
it should be noted that this causes the UI to fail as well:
Point being that a "loop" can span more than one or two jobs.
We hit this issue today. The UI dies even if the pipeline is paused. We thought our Concourses/network had just died...
Maybe if there's a use case for having self-referencing passed constraints
Thanks for all of your input!
IIRC this has already been addressed in a slightly different way - not through a validation, but preventing the infinite loop that used to crash the UI and displaying the loop:
It should be there in
I'll close this, for now, please let me know if I understood it incorrectly!