Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run multiline non-transactional DB migrations #3145

Closed
ddadlani opened this issue Jan 24, 2019 · 1 comment · Fixed by #3146
Closed

Cannot run multiline non-transactional DB migrations #3145

ddadlani opened this issue Jan 24, 2019 · 1 comment · Fixed by #3146
Assignees
Projects

Comments

@ddadlani
Copy link
Contributor

@ddadlani ddadlani commented Jan 24, 2019

Bug Report

When we try to add a Non-Transactional database migration that has more than one line, we error out with the following message:

Migration failed: pq: ALTER TYPE ... ADD cannot run inside a transaction block

This is because we merge all the statements into one and you cant run that on PostgreSQL. Offending lines:

case SQLNoTransaction:
migration.Statements = []string{migrationContents}
migration.Name = migrationName

  • Concourse version: v4.1.0+
  • Deployment type (BOSH/Docker/binary):
  • Infrastructure/IaaS:
  • Browser (if applicable):
  • Did this used to work? Not used before
@ddadlani ddadlani added this to Icebox in Runtime via automation Jan 24, 2019
@ddadlani ddadlani moved this from Icebox to In Flight in Runtime Jan 24, 2019
@ddadlani

This comment has been minimized.

Copy link
Contributor Author

@ddadlani ddadlani commented Jan 24, 2019

Encountered this bug when working on #3052

@vito vito closed this in #3146 Jan 25, 2019
Runtime automation moved this from In Flight to Done Jan 25, 2019
@vito vito added release/no-impact and removed triage labels Jan 25, 2019
@topherbullock topherbullock moved this from Done to Accepted in Runtime Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Runtime
Accepted
3 participants
You can’t perform that action at this time.