Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance regression] dashboard exhausting cpu #3748

Closed
xtreme-conor-nosal opened this issue Apr 17, 2019 · 4 comments · Fixed by #3870
Closed

[performance regression] dashboard exhausting cpu #3748

xtreme-conor-nosal opened this issue Apr 17, 2019 · 4 comments · Fixed by #3870
Assignees
Labels

Comments

@xtreme-conor-nosal
Copy link

@xtreme-conor-nosal xtreme-conor-nosal commented Apr 17, 2019

Bug Report

Rendering the dashboard uses excessive amounts of cpu. Usage remains high even if the animations are outside the viewport, or if no jobs are running (no animations)

Steps to Reproduce

Run many (>150) jobs simultaneously, view low density dashboard.

Expected Results

Dashboard should not consume all cpu. Cpu usage should drop if animations are outside the viewport.

Actual Results

Browser renders at < 5 FPS
Screen Shot 2019-04-17 at 12 04 58 PM

Version Info

  • Concourse version: 5.1.0
  • Deployment type (BOSH/Docker/binary): BOSH
  • Infrastructure/IaaS: GCP
  • Browser (if applicable): Chrome
  • Did this used to work? Yes in 5.0.1
@xtreme-conor-nosal xtreme-conor-nosal changed the title dashboard animations exhausting cpu [performance regression] dashboard animations exhausting cpu Apr 17, 2019
@jama22

This comment has been minimized.

Copy link
Member

@jama22 jama22 commented Apr 17, 2019

quick clarification @xtreme-conor-nosal , is this increase of CPU on your local computer or on the web node (ATC)

@xtreme-conor-nosal

This comment has been minimized.

Copy link
Author

@xtreme-conor-nosal xtreme-conor-nosal commented Apr 17, 2019

On the local computer. The browser struggles to render the animations.

@xtreme-conor-nosal xtreme-conor-nosal changed the title [performance regression] dashboard animations exhausting cpu [performance regression] dashboard exhausting cpu Apr 17, 2019
@xtreme-conor-nosal

This comment has been minimized.

Copy link
Author

@xtreme-conor-nosal xtreme-conor-nosal commented Apr 17, 2019

Just checked again now that our concourse is idle, and browser rendering is still slow. It's not related to the animations.

@xtremerui

This comment has been minimized.

Copy link
Contributor

@xtremerui xtremerui commented Apr 22, 2019

I think when hitting dashboard of ci.concorse-ci.org the browser renders slower in 5.1 too.

@pivotal-jamie-klassen pivotal-jamie-klassen self-assigned this May 8, 2019
pivotal-jamie-klassen added a commit that referenced this issue May 9, 2019
#3748

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
@vito vito added the paused label May 13, 2019
pivotal-jamie-klassen added a commit that referenced this issue May 15, 2019
#3748

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue May 15, 2019
by modifying old algorithm to avoid infinite recursion.

#3748

Signed-off-by: James Thomson <jthomson@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue May 15, 2019
* yarn script
* ci task in PR pipeline

#3748

Signed-off-by: James Thomson <jthomson@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue May 15, 2019
by modifying old algorithm to avoid infinite recursion.

#3748

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: James Thomson <jthomson@pivotal.io>
pivotal-jamie-klassen added a commit that referenced this issue May 15, 2019
* yarn script
* ci task in PR pipeline

#3748

Signed-off-by: James Thomson <jthomson@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
@vito vito closed this in #3870 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.