Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: don't cache 'not found' credential responses #3895

Open
eedwards-sk opened this issue May 21, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@eedwards-sk
Copy link

commented May 21, 2019

continuing from #2924

What challenge are you facing?

The current credential caching behavior introduced in 5.2.0 caches a 'not found' response.

This requires waiting for the cache to expire to retrieve a value that was missing.

What would make this better?

By default, do not cache a 'not found' response.

Are you interested in implementing this yourself?

No :(

I seek the help of our glorious contributors.

ralekseenkov added a commit to ralekseenkov/concourse that referenced this issue Jun 12, 2019

Added separate duration for secret not found responses
Fixes concourse#3895

Signed-off-by: Roman Alekseenkov <ralekseenkov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.