Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force resource check from web UI #3051

Merged
merged 3 commits into from Jan 16, 2019
Merged

Force resource check from web UI #3051

merged 3 commits into from Jan 16, 2019

Conversation

@pivotal-jamie-klassen
Copy link
Contributor

pivotal-jamie-klassen commented Jan 15, 2019

mhuangpivotal and others added 3 commits Jan 10, 2019
#688

Signed-off-by: Mark Huang <mhuang@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
#688

Signed-off-by: Mark Huang <mhuang@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
#688

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
@pivotal-jamie-klassen pivotal-jamie-klassen self-assigned this Jan 15, 2019
@vito vito added this to the v5.0.0 milestone Jan 16, 2019
@vito
vito approved these changes Jan 16, 2019
Copy link
Member

vito left a comment

Tested it out locally, works like a charm!

My only feedback was that I found the spinner kind of hard to notice. I expected the button to turn into a spinner or something - maybe because I had the spinner fullscreen, I didn't even notice the spinner until I checked the issue comments and saw that there is one off to the right.

@vito vito merged commit 1dc23e7 into master Jan 16, 2019
5 checks passed
5 checks passed
DCO DCO
Details
WIP Ready for review
Details
concourse-ci/testflight Concourse CI build success
Details
concourse-ci/unit Concourse CI build success
Details
concourse-ci/watsjs Concourse CI build success
Details
@vito vito deleted the feature/688 branch Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.