Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atc, web: Pin comment for v5.0.0 upgrade #3064

Merged
merged 6 commits into from Jan 18, 2019
Merged

atc, web: Pin comment for v5.0.0 upgrade #3064

merged 6 commits into from Jan 18, 2019

Conversation

@pivotal-jamie-klassen
Copy link
Contributor

pivotal-jamie-klassen commented Jan 16, 2019

Fixes #3007

mhuangpivotal and others added 4 commits Jan 16, 2019
#3007

Signed-off-by: Mark Huang <mhuang@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
#3007

Signed-off-by: Mark Huang <mhuang@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
#3007

Signed-off-by: Mark Huang <mhuang@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
#3007

Signed-off-by: Mark Huang <mhuang@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
Signed-off-by: Mark Huang <mhuang@pivotal.io>
Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
Copy link
Member

vito left a comment

one small tweak! (should capitalize the 'concourse' in the pin message)

#3007

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
@pivotal-jamie-klassen pivotal-jamie-klassen changed the title Pin comment for v5.0.0 upgrade atc, web: Pin comment for v5.0.0 upgrade Jan 18, 2019
@vito vito added this to the v5.0.0 milestone Jan 18, 2019
@vito

This comment has been minimized.

Copy link
Member

vito commented Jan 18, 2019

Tested it out locally via docker-compose. It was actually pretty easy:

$ docker-compose -f docker-compose-4.2.2.yml up
$ fly -t l login -u test -p test
$ fly -t l set-pipeline -p booklit -c booklit.yml
$ fly -t l unpause-pipeline -p booklit
# run the pipeline, pause a resource
$ docker-compose up --build
# upgrades in-place, preserving and migrating db, and adding new web/worker

The paused resource switched to pinned, and the message appeared in the UI.

👏

@vito
vito approved these changes Jan 18, 2019
@vito vito merged commit 7dfacc6 into master Jan 18, 2019
5 checks passed
5 checks passed
DCO DCO
Details
WIP Ready for review
Details
concourse-ci/testflight Concourse CI build success
Details
concourse-ci/unit Concourse CI build success
Details
concourse-ci/watsjs Concourse CI build success
Details
@vito vito deleted the feature/3007 branch Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.