Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prune all stalled workers instead of just one at the time. #3248

Merged
merged 1 commit into from Mar 18, 2019

Conversation

@aledeganopix4d
Copy link
Contributor

aledeganopix4d commented Feb 8, 2019

I couldn't find any existing test checking the functionality of the existing prune-worker command and thus making a bit hard to add a test for this additional command.
I'm willing to try to add some test if given some general direction.

Signed-off-by: Alessandro Degano alessandro.degano@pix4d.com

Signed-off-by: Alessandro Degano <alessandro.degano@pix4d.com>
@ghost
ghost approved these changes Feb 11, 2019
@ghost

This comment has been minimized.

Copy link

ghost commented Feb 11, 2019

Very useful feature. I miss it very much, especially, workers tent to prune on cloud.
I haven't found anything bad in this code. Approved.

@vito
vito approved these changes Mar 12, 2019
Copy link
Member

vito left a comment

You're right, it looks like there aren't any tests for prune-worker.

Sorry for the delay, by the way - had to focus on getting 5.0 out so PRs went idle for a while.

It's our own fault that there aren't tests, so I don't want to make you write them. If you're interested, though, you could probably find your way by using the other tests as a reference.

I'll leave this open for a bit longer in case you want to add tests, but if not that's cool too - just let me know!

@vito

This comment has been minimized.

Copy link
Member

vito commented Mar 18, 2019

Merging - thanks!

@vito vito merged commit 7b5486f into concourse:master Mar 18, 2019
4 checks passed
4 checks passed
WIP Ready for review
Details
concourse-ci/testflight Concourse CI build success
Details
concourse-ci/unit Concourse CI build success
Details
concourse-ci/watsjs Concourse CI build success
Details
@aledeganopix4d

This comment has been minimized.

Copy link
Contributor Author

aledeganopix4d commented Mar 19, 2019

@vito sorry for not replying earlier and thanks for the merge.
I wouldn't have had time right now to look into tests anyway. But I'll try and keep it in my personal backlog!

@aledeganopix4d aledeganopix4d deleted the aledeganopix4d:add_prune_all_workers branch Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.