Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
web: add pause button to top bar of pipeline view #3475
This is really great! It's very encouraging to see some really effective reuse of some of the abstractions we've been defining in this project (Effects, inline styles).
There's a couple of UI polish things to help with the user experience:
Whatever of those you have the bandwidth and interest to do is awesome. We'll leave this open until we hear further from you, but either way this is much appreciated.
There's an example for the paused divider color at https://github.com/concourse/concourse/blob/master/web/elm/src/TopBar/Styles.elm#L260-L266 with tests at https://github.com/concourse/concourse/blob/master/web/elm/tests/TopBarTests.elm#L216-L221 and https://github.com/concourse/concourse/blob/master/web/elm/tests/TopBarTests.elm#L296-L301
There's an example of the hover and unauthorized/unauthenticated behaviour at https://github.com/concourse/concourse/blob/master/web/elm/src/Resource/Resource.elm#L960-L1006 (the resource check button) with tests at https://github.com/concourse/concourse/blob/master/web/elm/tests/ResourceTests.elm#L2631-L2708 and https://github.com/concourse/concourse/blob/master/web/elm/tests/ResourceTests.elm#L2719-L2811 and https://github.com/concourse/concourse/blob/master/web/elm/tests/ResourceTests.elm#L3062-L3136.
Finally, there's an example of changing to a spinner and back at https://github.com/concourse/concourse/blob/master/web/elm/src/Resource/Resource.elm#L1351-L1400 (the resource pin button) with tests at https://github.com/concourse/concourse/blob/master/web/elm/tests/ResourceTests.elm#L2407-L2427.
vito left a comment
Ooh, this is neat! At first I was worried that this added it to the breadcrumb, so I was concerned about potential mis-clicks, but it's actually off to the right by the pin icon, and only shows when viewing the pipeline itself, so
For anyone curious, here's how it looks:
Echoing @pivotal-jamie-klassen's statement it's really nice to see how far we've come in the web UI. Really encouraging seeing external folks able to hop in and add substantial features like this without too much trouble. Nice job everyone!