New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web: add red border to failing steps #4164
Conversation
#4111 Signed-off-by: James Thomson <jthomson@pivotal.io>
no shifting when a step fails #4111 Signed-off-by: Jamie Klassen <cklassen@pivotal.io> Co-authored-by: James Thomson <jthomson@pivotal.io>
web/elm/src/Build/Styles.elm
Outdated
StepStateFailed -> | ||
Colors.failure | ||
|
||
_ -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👻 Scope creeping, but can we do the same for errored steps? Those are in the same boat: they cause a build failure (well, error) but are hard to notice when auto-collapsed.
I don't think there are any other states we care about. 🤔
Also maybe we can just explicitly write out all the states here so the compiler will help us find places to update if/when we add another state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a prototype, but let's get @Lindsayauchin in on this sooner rather than later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vito @pivotal-jamie-klassen Makes sense. I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lindsayauchin @pivotal-jamie-klassen More 👻 scope creep: what do you think of adding a yellow border for running steps, since they're auto-collapsed too?
some context: #2608 (comment)
#4111 Signed-off-by: James Thomson <jthomson@pivotal.io> Co-authored-by: Jamie Klassen <cklassen@pivotal.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
wats test failing, running locally it sometimes passes when it doesn't timeout |
hey, I just wanted to say that this is amazing ❤️ ! thank you all! (@xtremerui shares the same thought!) |
fixes #4111
Release Note