New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --team
flag to fly pause-pipeline
and fly hide-pipeline
commands
#5917
Conversation
concourse#5215 Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
concourse#5215 Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! The --team
flags make fly
a lot more convenient when you have to work across multiple teams.
Tested it out and it works great! Just rerunning one of the integration suites which looks like it flaked, but after that I'll merge
@aoldershaw - Thanks for the review! For that 1 PR check, I assumed that it flaked. But when I try to view the job, I just get a spinning wheel. So if there is something legitimate there, I might need some help getting the failure details. |
@owenfarrell looks like it was just a flake, as it passed the second time around. You should have been added to the contributors team after opening a PR, which has access/rerun the PR builds 🤷 |
Just sent you an invite to the @concourse/contributors team |
@aoldershaw - Thanks! FWIW - when trying to access the link from the PR (which includes the Not sure if there's an ops issue there that needs some attention. 🤷♂️ |
Huh, interesting. We'll take a look. Now that you're on the contributor team, do you still get the spinning wheel when accessing it directly? (after re-logging in to ci.concourse-ci.org) You'll also have to accept the invitation to the contributors team by visiting https://github.com/orgs/concourse/teams/contributors, I think |
That did the trick - thanks! Root cause: I was getting a 403 on the API call (e.g. https://ci.concourse-ci.org/api/v1/builds/2028256) |
--team
flag to fly pause-pipeline
and fly hide-pipeline
commands
What does this PR accomplish?
Feature
Changes proposed by this PR:
--team
flag forfly pause-pipelines
command--team
flag forfly hide-pipeline
commandNotes to reviewer:
The... healthy amount of whitespace change to
fly/integration/pause_pipeline_test.go
is because there was a test outside of theDescribe
block.Contributor Checklist
Reviewer Checklist
--help
text).