Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --team flag to fly pause-pipeline and fly hide-pipeline commands #5917

Merged
merged 2 commits into from Jul 28, 2020

Conversation

owenfarrell
Copy link
Member

@owenfarrell owenfarrell commented Jul 28, 2020

What does this PR accomplish?

Feature

Changes proposed by this PR:

  • Add --team flag for fly pause-pipelines command
  • Add --team flag for fly hide-pipeline command

Notes to reviewer:

The... healthy amount of whitespace change to fly/integration/pause_pipeline_test.go is because there was a test outside of the Describe block.

Contributor Checklist

Reviewer Checklist

  • Code reviewed
  • Tests reviewed
  • Documentation reviewed
  • Release notes reviewed
  • PR acceptance performed
  • New config flags added? Ensure that they are added to the BOSH and Helm packaging; otherwise, ignored for the integration tests (for example, if they are Garden configs that are not displayed in the --help text).

concourse#5215

Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
concourse#5215

Signed-off-by: Owen Farrell <owen.farrell@gmail.com>
Copy link
Contributor

@aoldershaw aoldershaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The --team flags make fly a lot more convenient when you have to work across multiple teams.

Tested it out and it works great! Just rerunning one of the integration suites which looks like it flaked, but after that I'll merge

@owenfarrell
Copy link
Member Author

@aoldershaw - Thanks for the review!

For that 1 PR check, I assumed that it flaked. But when I try to view the job, I just get a spinning wheel. So if there is something legitimate there, I might need some help getting the failure details.

@aoldershaw
Copy link
Contributor

@owenfarrell looks like it was just a flake, as it passed the second time around. You should have been added to the contributors team after opening a PR, which has access/rerun the PR builds 🤷

@aoldershaw aoldershaw merged commit 3bc4028 into concourse:master Jul 28, 2020
@owenfarrell owenfarrell deleted the team_flag branch July 28, 2020 14:56
@aoldershaw
Copy link
Contributor

Just sent you an invite to the @concourse/contributors team

@owenfarrell
Copy link
Member Author

@aoldershaw - Thanks!

FWIW - when trying to access the link from the PR (which includes the BUILD_ID as a path parameter), I get the spinning wheel. But I can browse via the main screen to the pr pipeline and view the job history no problem... just means I have to walk my way back through history to see what version triggered this PR build.

Not sure if there's an ops issue there that needs some attention. 🤷‍♂️

@aoldershaw
Copy link
Contributor

aoldershaw commented Jul 28, 2020

Huh, interesting. We'll take a look.

Now that you're on the contributor team, do you still get the spinning wheel when accessing it directly? (after re-logging in to ci.concourse-ci.org)

You'll also have to accept the invitation to the contributors team by visiting https://github.com/orgs/concourse/teams/contributors, I think

@owenfarrell
Copy link
Member Author

That did the trick - thanks!

Root cause: I was getting a 403 on the API call (e.g. https://ci.concourse-ci.org/api/v1/builds/2028256)

@aoldershaw aoldershaw changed the title Add --team to fly commands Add --team flag to fly pause-pipeline and fly hide-pipeline commands Aug 18, 2020
@aoldershaw aoldershaw added the release/undocumented This didn't warrant being documented or put in release notes. label Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement release/undocumented This didn't warrant being documented or put in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants