Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix algorithm considering reruns as new builds #7144

Merged
merged 1 commit into from Jun 18, 2021
Merged

Conversation

taylorsilva
Copy link
Member

Changes proposed by this PR

closes #6988

Notes to reviewer

If you want to do acceptance: #6988 (comment)

Release Note

  • Fixes pipelines getting stuck with the same inputs when a job upstream of a job with version: every succeeds and is rerun

Previously `version: every` would treat reruns as the next builds to
consider during the build cursor logic which resulted in it finding the
same inputs every time because with no new build triggered no new build
pipes and therefore no new cursor would be created

Signed-off-by: Taylor Silva <tsilva@pivotal.io>
Co-authored-by: Alex Suraci <asuraci@pivotal.io>
@taylorsilva taylorsilva requested a review from a team as a code owner June 8, 2021 20:44
@taylorsilva taylorsilva added bug release/undocumented This didn't warrant being documented or put in release notes. labels Jun 8, 2021
Copy link
Contributor

@clarafu clarafu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did acceptance and it fixes the bug :)

@taylorsilva taylorsilva merged commit 0ed34f4 into master Jun 18, 2021
@taylorsilva taylorsilva deleted the issue/6988 branch June 18, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug release/undocumented This didn't warrant being documented or put in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jobs with both "passed" and "version:every" constraints fails to auto trigger build on a special case
2 participants