Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using zfs #179

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@evanphx
Copy link

commented Mar 2, 2018

This adds the alpine zfs package so that docker can use the zfs storage backend if it's available.

Additionally, this purges docker entirely before exitting to prevent any resource leakage (something that, no surprise, happens when you use the zfs storage backend nested. The zfs filesystems that the inner docker creates are left as zombies on the host system)

Add support for using zfs
This adds the alpine zfs package so that docker can use the zfs
storage backend if it's available.

Additionally, this purges docker entirely before exitting to prevent
any resource leakage (something that, no surprise, happens when
you use the zfs storage backend nested. The zfs filesystems that the
inner docker creates are left as zombies on the host system)
@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Mar 2, 2018

@evanphx Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Mar 2, 2018

@evanphx Thank you for signing the Contributor License Agreement!

@vito

This comment has been minimized.

Copy link
Member

commented Apr 11, 2018

Interesting catch for the docker system prune. I wonder if that explains other leaks too?

Do you think a test could be added to out_test.go for the prune call?

@vito

This comment has been minimized.

Copy link
Member

commented May 29, 2018

@evanphx Do you have time to add a test for this? If your hands are tied I can add it myself (shouldn't take long), just poking to keep the PR alive. :)

@vito

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

Closing due to inactivity, but happy to review once you've got time again!

@vito vito closed this Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.