New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searches all branches when tag filter is provided and branch isn't #225

Merged
merged 6 commits into from Dec 4, 2018

Conversation

Projects
None yet
4 participants
@goddenrich
Copy link
Contributor

goddenrich commented Nov 19, 2018

This has been attempted before In #176 and #165. I think this works now. I know this may be made obsolete by spaces but Im not sure when this will land and we have a need for this behaviour now.
Signed-off-by: Richard Godden goddenrich@gmail.com

searches all branches when tag filter is provided and branch isnt
Signed-off-by: Richard Godden <goddenrich@gmail.com>
@pivotal-issuemaster

This comment has been minimized.

Copy link

pivotal-issuemaster commented Nov 19, 2018

@goddenrich Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Copy link

pivotal-issuemaster commented Nov 19, 2018

@goddenrich Thank you for signing the Contributor License Agreement!

@vito
Copy link
Member

vito left a comment

Thanks for reviving this! Happy to merge it for now even though spaces is on the horizon (and with it we may begin phasing this resource out in favor of separate ones for narrower workflows, e.g. tag-based vs. commit-based).

Show resolved Hide resolved assets/check Outdated
Show resolved Hide resolved assets/check Outdated
Show resolved Hide resolved assets/in
Show resolved Hide resolved assets/in Outdated
Show resolved Hide resolved assets/in Outdated

rgodden added some commits Nov 20, 2018

@vito

vito approved these changes Dec 3, 2018

Copy link
Member

vito left a comment

Woops, didn't see you had pushed a merge, sorry for the delay!

This looks good to me. I can merge this soon, just checking in to make sure it's ready since it's been a while since the last update (my fault).

@goddenrich

This comment has been minimized.

Copy link
Contributor

goddenrich commented Dec 3, 2018

Feel free to merge its good on my end

@goddenrich goddenrich closed this Dec 3, 2018

@goddenrich goddenrich reopened this Dec 3, 2018

@vito vito merged commit 57614ae into concourse:master Dec 4, 2018

2 checks passed

ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
concourse-ci/status Concourse CI build success
Details
@vito

This comment has been minimized.

Copy link
Member

vito commented Dec 4, 2018

@goddenrich thanks!

@goddenrich goddenrich deleted the goddenrich:tags-across-all-branches branch Dec 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment