Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Create a scan queue for resource checking #15

Closed

Conversation

@pivotal-jwinters
Copy link
Contributor

pivotal-jwinters commented Nov 15, 2018

proposal

Signed-off-by: Jamie Klassen cklassen@pivotal.io

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
* two steps instead of one does introduce more complexity
* we would need to decide if the check handler would poll for a result in the
database or if requests to the check endpoint would be async and anyone that
requires a response would need to poll a separate endpoint.

This comment has been minimized.

Copy link
@timrchavez

timrchavez Nov 16, 2018

I vote for async check endpoint. If the time it took to do version checking could be bounded to some reasonable # or if we were only talking about one client (e.g. fly), I might be more in favor of waiting for a response since it's simpler, but as it is, I don't think it can be bounded short of picking some arbitrarily high timeout (e.g. we're dealing with a 1.5GB and growing mono repo that takes about 4-6m to fully clone onto a worker) in your client which could have you potentially trading one set of problems for another.

@vito

This comment has been minimized.

Copy link
Member

vito commented May 13, 2019

This has turned into real work and wasn't significantly user-facing so I think we'll just close it out. 👍

@vito vito closed this May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.