Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: notification resources #28

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

@vito
Copy link
Member

@vito vito commented May 21, 2019

Rendered

Related to, but not dependent on #24.

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
@kallisti5
Copy link

@kallisti5 kallisti5 commented Feb 3, 2020

Feedback? One thing we really miss from buildbot is "State change only" notifications.
Example:

  • Success
  • Success
  • Success
  • Error!
  • Error!
  • Success

Instead of 6 notifications, having the option of only 2 would be a lot better from a "preventing spam" standpoint. We rolled our own custom notification plugin, and still wasn't able to accomplish it. (no persistent data between notification plugin runs)

@vito
Copy link
Member Author

@vito vito commented Feb 7, 2020

@kallisti5 Good call! I've listed that under 'Motivation' so I don't forget. 👍

@agonbina
Copy link

@agonbina agonbina commented Mar 23, 2020

Maybe this is already addressed in the specification, but would also be interesting to version notifications so that you can update them to avoid too much spam (ex. a slack notification to notify build started, can then be updated to "failed/succeeded") etc.

@Anonymous-Coward
Copy link

@Anonymous-Coward Anonymous-Coward commented May 12, 2021

I was led here from here.

Noob question: why not replace a dedicated notifications resource with a dedicated events resource, with events being able to trigger arbitrary tasks/jobs? Would increase the flexibility and power of concourse overall, and bring it closer to its stated purpose of being an automation tool.

The current approach, of triggering jobs only on get of resources is often not that convenient. Events, OTOH, are quite flexible.

@kallisti5
Copy link

@kallisti5 kallisti5 commented May 12, 2021

I think "onFailure" does exist for notifications now? ... so this one might be a little less relevant than it once was. State change only events would be a nice feature though.

@Anonymous-Coward
Copy link

@Anonymous-Coward Anonymous-Coward commented May 13, 2021

I think "onFailure" does exist for notifications now? ... so this one might be a little less relevant than it once was. State change only events would be a nice feature though.

I was thinking of more generic events - maybe arbitrary identifiers you can attach to success, failure and finally - just like exception handling. Then, specify the event as a trigger for another job in the same pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants