New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace progressSeekReaderAt with progressReader #78

Merged
merged 1 commit into from Aug 31, 2017

Conversation

Projects
None yet
5 participants
@krishicks
Contributor

krishicks commented Aug 2, 2017

This fixes the problem where uploading a file would show a wildly incorrect speed for the upload; this is due to how the AWS client scans the file to determine its size prior to actually uploading it.

This pull request closes issue #76.

Kris Hicks
Replace progressSeekReaderAt with progressReader
This fixes the problem where uploading a file would show a wildly
incorrect speed for the upload; this is due to how the AWS client scans
the file to determine its size prior to actually uploading it.

@topherbullock topherbullock added this to the v3.4.x milestone Aug 8, 2017

@vito vito added the bump/patch label Aug 25, 2017

@vito vito removed this from the v3.4.x milestone Aug 25, 2017

@jtarchie

This comment has been minimized.

Show comment
Hide comment
@jtarchie

jtarchie Aug 31, 2017

Contributor

For acceptance: A pipeline that downloaded a multi gigabyte file and then uploaded.

With the current s3 resource, I saw the upload show that it uploaded the the file at 2TB/s.
With this PR, I saw the upload show at a more sane 56.05 MB/s.

Looks good to me!

Thanks for the PR!

Contributor

jtarchie commented Aug 31, 2017

For acceptance: A pipeline that downloaded a multi gigabyte file and then uploaded.

With the current s3 resource, I saw the upload show that it uploaded the the file at 2TB/s.
With this PR, I saw the upload show at a more sane 56.05 MB/s.

Looks good to me!

Thanks for the PR!

@jtarchie jtarchie merged commit 2f2fe2a into concourse:master Aug 31, 2017

1 check passed

ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details

@jama-pivotal jama-pivotal added this to the v3.5.0 milestone Sep 19, 2017

cappyzawa pushed a commit to cappyzawa/s3-resource that referenced this pull request Feb 5, 2018

Merge pull request #78 from krishicks/fix-upload-progress-bar
Replace progressSeekReaderAt with progressReader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment