This repository has been archived by the owner. It is now read-only.

Add CSS classes for exotic ANSI modes #2

Merged
merged 1 commit into from Feb 14, 2018

Conversation

Projects
None yet
2 participants
@evanphx
Contributor

evanphx commented Feb 4, 2018

Filling in for faint (which was supported but didn't have a class) and adding support for Fraktur and framed via vito/elm-ansi#2, this adds rendering for these exotic modes.

Users can use them to make their build outputs easier to follow beyond just using the basic ansi colors. The framed css is simple and could be changed to whatever framing style y'all deem necessary.

Examples:

Faint:
build-tests 21 - concourse 2018-02-03 16-13-41

Fraktur:
build-tests 21 - concourse 2018-02-03 16-14-34

@vito

This comment has been minimized.

Member

vito commented Feb 5, 2018

Just to make sure, this won't download the font-face until it's actually used, right?

@evanphx

This comment has been minimized.

Contributor

evanphx commented Feb 5, 2018

@vito That's correct. The browser won't even download the font until you unfurl a build log where it's used.

@vito vito added the enhancement label Feb 14, 2018

@vito

This comment has been minimized.

Member

vito commented Feb 14, 2018

Gonna go ahead and pull this in, thanks!

Note: we'll still need to bump the elm-ansi dependency (and I still need to bump that) before these have any effect.

@vito vito merged commit 522cc0e into concourse:master Feb 14, 2018

@vito vito added this to the v3.9.1 milestone Feb 26, 2018

@evanphx evanphx deleted the evanphx:f-exotic branch Feb 27, 2018

vito referenced this pull request Jul 23, 2018

fonts, colors and letter spacing
concourse/concourse#2392 and concourse/concourse#2370

Signed-off-by: Jamie Klassen <cklassen@pivotal.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.