Fixed session default locale, it now checks user's default language. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -48,6 +48,16 @@ public function getSessionDefaultLocale() { | |||
| if(isset($_COOKIE['DEFAULT_LOCALE'])) { | |||
| return $_COOKIE['DEFAULT_LOCALE']; | |||
| } | |||
|
|
|||
| $u = new User(); | |||
| if ($u->isLoggedIn()) { | |||
There was a problem hiding this comment.
isLoggedIn is a static method, so you can call it without instantiating the User class. What about this?
if(User::isLoggedIn()) {
$u = new User();
...
}There was a problem hiding this comment.
I changed that as you suggested. Thanks.
tylerryan
added a commit
that referenced
this pull request
Aug 28, 2013
…in-user Fixed session default locale, it now checks user's default language.
|
Thanks, nice to have it honor the preference from the user object . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User's default language was not used with internationalization addon.
This caused site to use predefined default for the site, even if user had selected different default.
Now default language will be returned by user's choise if site has corresponding locale available.
If current page is anything but homepage,
en_USis allowed even if it is not available in content sections. That is because site might not have it, but you might like to use dashboard in english on a non english site.In homepage only existing content section locales are allowed even for user's default, because existing locale is needed in case of forwarding rules.