Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Conversation Lightbox doesn't work #1557

Closed
Mnkras opened this Issue · 3 comments

3 participants

@Mnkras

When I insert a link and click lightbox, (Image or Ajax) it doesn't seem to do anything.

@ChrisHougard

The problem is the htmLawed config does not allow for data-concrete5-link-type and data-concrete5-link-launch. I tried to write a spec string for it (a=data-concrete5-link-type(oneof=image|ajax), data-concrete5-link-launch(oneof=lightbox-image)) but htmLawed is only using the data-concrete part of the name because the regex used to parse (^([a-z:\-\*]+)(?:\((.*?)\))?, line 386) does not allow for numbers. Changing that to include numbers made it read in the full property name, but I still can't get it to use the spec because the number is making it fail somewhere else in the code. This should be fixed in htmLawed 1.2.

Thinking the best way to fix this for now is going to be with a hook.

@ChrisHougard

Hook isn't going to work because I run into another spot not allowing numbers in the attribute name. I fixed this by doing a string replace to get rid of the 5. Ugly but I'm not sure how else to fix it until the updated version of htmLawed is released.

@aembler
Owner

Going to remove redactor as a conversation editor.

@aembler aembler closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.