Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orphaned Blocks Option in Add Block Panel #3234

Closed
aembler opened this issue Dec 22, 2015 · 6 comments
Closed

Orphaned Blocks Option in Add Block Panel #3234

aembler opened this issue Dec 22, 2015 · 6 comments
Labels
Product Areas:In-Page Editing Product Areas:UX Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Enhancement A need for something new.

Comments

@aembler
Copy link
Member

aembler commented Dec 22, 2015

We could add another item after "Gathering tiles" in the add block panel that's "Non-Displayed Blocks" or "Orphaned Blocks" (gotta find a better name for this.) that shows the blocks in a list similar to the clipboard. You could either click a delete icon to delete the block permanently or drag it into the page.

When loading the add block panel, we could check to see whether there were any areas on the page that weren't rendered. We'd want to make sure this was performant, and didn't needlessly slow down the loading of the add block panel all the time. This would also have to respect layouts. This would determine whether to show this option. Alternatively, we could just always show it. Less elegant but easier for development and less of a resource drain on every panel load.

This came from #195

@aembler aembler added Type:Enhancement A need for something new. Status:Available Reviewed issue, it’s real, we’d review a pull request. priority:love to have labels Dec 22, 2015
@MrKarlDilkington
Copy link
Contributor

I really like this idea.

Especially for pages that have dynamically named or programmatically added areas.

@MrKarlDilkington
Copy link
Contributor

Another great use case for this is when users switch themes that use different area names.

From the forum:
http://www.concrete5.org/community/forums/themes/remove-elemental-content/

@jheanly
Copy link

jheanly commented Nov 30, 2016

Just came across the same issue as that highlighted by MrKarlDilkington. Would be great to be able to remove content from the database that is not actually displayed on the site (and hence remove from search results)

@JohntheFish
Copy link
Contributor

I would like to see thinking on this resurrected with the new layout engine being considered for v9. #6828
As well as orphaned blocks on a page-by-page basis, #195 highlights that a solution also needs to consider the problem of orphans in 1000s of pages, such as when a big site needs to change theme.

Updating the core for more effective and flexible (and hence greater use of) layouts will compound the problem.

@aembler aembler added this to In Discussion in Version 9 Roadmap via automation Jan 8, 2020
@aembler aembler moved this from In Discussion to Ready to Go in Version 9 Roadmap Aug 17, 2020
@aembler
Copy link
Member Author

aembler commented Aug 17, 2020

Just an update on this. I think this would work this way:

  1. When you open the add panel, the add controller would retrieve all areas dynamically from the template on your current page. This would be the set of valid areas.
  2. Then, the add controller would retrieve all blocks in all areas for the current recent page version.
  3. If there are blocks in areas that aren't in the list of areas found in the page template, the Orphaned Blocks option would be shown in the dropdown. We only show it if there are blocks that are orphaned.
  4. Clicking the Orphaned blocks option loads the panel contents, just like clicking Containers or Clipboard does.
  5. The display of the orphaned blocks panel is just like Clipboard – we show a preview of a block, and the ability to drag it into the page, and a delete link.
  6. If you drag the block in the page, the block disappears from the panel, because you're changing its areas to the new area.
  7. If you click delete, your deleting that instance of the block from that area, which should also remove it from the panel.

I think the bulk tool sounds interesting but is a separate concern.

@aembler
Copy link
Member Author

aembler commented Jun 4, 2021

This is complete and will be in version 9.

@aembler aembler closed this as completed Jun 4, 2021
Version 9 Roadmap automation moved this from Ready to Go to Done Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Areas:In-Page Editing Product Areas:UX Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Enhancement A need for something new.
Projects
No open projects
Development

No branches or pull requests

4 participants