New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.2 regression does not allow for strings to be passed to getThumbnail method #5761

Closed
Seanom opened this Issue Jul 26, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@Seanom
Member

Seanom commented Jul 26, 2017

The following used to work:

$ih->getThumbnail( '/images/content/placeholder.jpg', 250, 250, true)->src;

after upgrading to 8.2.0 I'm noticing an error Call to a member function getFileStorageLocationObject() on string" I thought I'd been involved in with a previous issue where this was wrapped in a check to retrieve the storage location if it was not set. (Potentially one of the 8.2 RC versions)

if ($obj instanceof File) {
    $storage = $obj->getFileStorageLocationObject();
} else {
    $storage = $this->getStorageLocation();
}

Was this an intentional change to remove this (or am I going crazy, and it never made it's way into the core)

https://github.com/concrete5/concrete5/blob/develop/concrete/src/File/Image/BasicThumbnailer.php#L232

It does look like I can turn on basic_thumbnailer_generation_strategy = async to resolve this but feel this should work with the legacy option as well?

deek87 added a commit to deek87/concrete5 that referenced this issue Jul 31, 2017

aembler added a commit that referenced this issue Aug 9, 2017

Merge pull request #5778 from deek87/hotfix/thumbnailfromstring
Fixing issue #5761 - allowing legacy option to get image thumbnails f…

@aembler aembler closed this Aug 9, 2017

@Anticept

This comment has been minimized.

Show comment
Hide comment
@Anticept

Anticept Sep 20, 2017

I'm also having issues with this:

Exception Occurred: -snip-/updates/concrete5-8.2.1_remote_updater/concrete/src/File/Image/BasicThumbnailer.php:234 Call to a member function getFileStorageLocationObject() on string (0)

This error occurs every time the welcome/update window pops up, and nothing loads.

Happens on both 7.0 and 7.1

An addon is also affected by this.

I haven't created a new issue on this yet because I was not sure if this fix applies here, or if it made it into 8.2.1 stable.

Anticept commented Sep 20, 2017

I'm also having issues with this:

Exception Occurred: -snip-/updates/concrete5-8.2.1_remote_updater/concrete/src/File/Image/BasicThumbnailer.php:234 Call to a member function getFileStorageLocationObject() on string (0)

This error occurs every time the welcome/update window pops up, and nothing loads.

Happens on both 7.0 and 7.1

An addon is also affected by this.

I haven't created a new issue on this yet because I was not sure if this fix applies here, or if it made it into 8.2.1 stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment