Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer, 'Database is empty' #7152

Closed
a3020 opened this Issue Oct 4, 2018 · 3 comments

Comments

Projects
None yet
4 participants
@a3020
Copy link
Contributor

a3020 commented Oct 4, 2018

'Database is empty: There are already 284 tables in this database. concrete5 must be installed in an empty database.'

I understand this message from a developer point of view; it's the name of the precondition. But it's a bit confusing for end-users, I think.

afbeelding

@eskema

This comment has been minimized.

Copy link

eskema commented Oct 4, 2018

It think it should say the opposite:
‘Database not empty. (...)’

@jasteele12

This comment has been minimized.

Copy link
Contributor

jasteele12 commented Oct 4, 2018

Sounds confusing and redundant - why not give the user some useful information instead of "this database". I suspect there might be better ways to translate this into other languages:

t('Please enter the name of an empty database. %s has %d existing tables.', $db, $count);

(wink) I didn't take the time to look at the actual code...

@mlocati

This comment has been minimized.

Copy link
Collaborator

mlocati commented Oct 5, 2018

#7159 should fix this.

@aembler aembler closed this in #7159 Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.