Re: Make console command extendable from packages

[hissy]

This PR makes console command extendable from a Package, without adding the method directly to the Package class. This is an alternative plan of #2651

An example of package controller:

<?php 
namespace Concrete\Package\CommandPackageExample;

use Concrete\Package\CommandPackageExample\Console\Command\ExampleCommand;
use Core;

class Controller extends \Concrete\Core\Package\Package
{
    protected $pkgHandle = 'command_package_example';
    protected $appVersionRequired = '5.7.4.3';
    protected $pkgVersion = '0.1';
    protected $pkgAutoloaderMapCoreExtensions = true;

    public function getPackageName()
    {
        return t('Command Package Example');
    }

    public function getPackageDescription()
    {
        return t('An example package to add console commands.');
    }

    public function on_start()
    {
        if (Core::make('app')->isRunThroughCommandLineInterface()) {
            try {
                $app = Core::make('console');
                $app->add(new ExampleCommand());
            } catch (Exception $e) {}
        }
    }
}

[KorvinSzanto]

This looks like the right way to do it.

[aembler]

I like that.

[hissy]

Thanks! 😋