New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDPR - uID cleanup #6693

Merged
merged 8 commits into from Jul 16, 2018

Conversation

Projects
None yet
2 participants
@a3020
Copy link
Contributor

a3020 commented May 27, 2018

  • ConfigStore should have its entries deleted
  • ConversationSubscriptions should have its entries deleted
  • PermissionAccessEntityUsers should have its entries deleted
  • DownloadStatistics should have uID set to 0 or some kind of USER_DELETED constant when a user is deleted
  • FileSets should have its entities deleted if the type is private.
  • FileSets should have uID set to 0 or some kind of USER_DELETED constant when a user is deleted if their type is public
  • NotificationAlerts --> delete? But foreign key is set to ON DELETE RESTRICT.
  • authTypeConcreteCookieMap

Related: #6676

a3020 added some commits May 27, 2018

Set DownloadStatistics to '0' when user is deleted.
The uID field doesn't allow NULL values, but does allow
0. We don't delete the record, because then stats would be lost.
Delete private file sets if user is deleted
Use the `delete` method instead of just a query because
the FileSet also has references in other tables.

@a3020 a3020 force-pushed the a3020:gdpr/uid_cleanup branch from 9a90255 to e8c13b0 May 27, 2018

@a3020

This comment has been minimized.

Copy link
Contributor

a3020 commented May 27, 2018

@aembler I'm going to need some help to finish the last item. Would you mind giving me some assistance?

@a3020

This comment has been minimized.

Copy link
Contributor

a3020 commented May 27, 2018

Regarding the NotificationAlerts table, I think it's handled here https://github.com/concrete5/concrete5/blob/develop/concrete/src/Entity/User/User.php#L24. So I think we can also mark that table as done.

@a3020

This comment has been minimized.

Copy link
Contributor

a3020 commented Jul 14, 2018

@aembler may I bring this PR under your attention again? I noticed it wasn't merged in the 8.4.1 release.

@aembler aembler merged commit f948e4a into concrete5:develop Jul 16, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@a3020 a3020 deleted the a3020:gdpr/uid_cleanup branch Jul 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment