Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing external links #7004

Merged
merged 3 commits into from Sep 5, 2018

Conversation

Projects
None yet
3 participants
@mlocati
Copy link
Collaborator

mlocati commented Aug 24, 2018

  • Call canEditPageProperties instead of canDeletePage to check if a user can edit an existing external link (ref)
  • Add a missing </div>
  • Submit button text should be Save instead of Add when editing an existing external link
  • Avoid deprecated code
  • Avoid accessing undefined vars (ref. #4723)
@mlocati

This comment has been minimized.

Copy link
Collaborator Author

mlocati commented Aug 24, 2018

I also normalized the size of the Add External Link and Edit External Link dialogs.
Before we had the height of the Add dialog was 260 pixels (a bit too smal), and the height of the Edit dialog was 400 pixels (ways too big).

mlocati added some commits Aug 24, 2018

@mlocati mlocati force-pushed the mlocati:fix-external-link-edit branch from e98b767 to 4802168 Sep 5, 2018

@aembler aembler merged commit 103bfa1 into concrete5:develop Sep 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mlocati mlocati deleted the mlocati:fix-external-link-edit branch Sep 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.