Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative urls when the canonical url isn't set #4021

Closed

Conversation

KorvinSzanto
Copy link
Member

If this merges I'll open a similar pull for version 8.

@aembler
Copy link
Member

aembler commented Jul 18, 2016

I'm concerned about putting this in a relatively small release (5.7.5.9) when it has some far-reaching implications. This could very possibly break lots of sites that use the URL class for generating URLs that they use in APIs (turning them relative when they need to be absolute so that other services can consume them.) Not against the change, I think it's a good one – but I think it should be in 8.0 only going forward.

@KorvinSzanto
Copy link
Member Author

Alright we can do that

@katzueno
Copy link
Contributor

@KorvinSzanto: Did you already include this onto Ver.8?

@KorvinSzanto KorvinSzanto deleted the feature/relative_urls branch August 15, 2016 22:19
@KorvinSzanto
Copy link
Member Author

I have not

@KorvinSzanto
Copy link
Member Author

I have opened a PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants